openstack/networking-bgpvpn - networking-bgpvpn - OpenDev: Free Software Needs Free Tools

tenant replaced to project
Change-Id: Iefa611cbffedd89eb882daedd910e16755bece0e
Signed-off-by: Ivan Anfimov <lazekteam@gmail.com>

As discussed at the Epoxy PTG meeting, run an automated
upgrade tool to make code python 3.9+ compliant.
Result of running:
$ pyupgrade --py39-plus $(git ls-files | grep ".py$")
Fixed PEP8 errors introduced by pyupgrade by running:
$ autopep8 --select=E127,E128,E501 --max-line-length 79 -r \
 --in-place networking_bgpvpn
Also did manual updates as necessary to fix other errors
and warnings after above commands.
Inspired by Octavia and Nova [0].
[0] https://review.opendev.org/c/openstack/nova/+/896986
Change-Id: Iac7a039ad6924de14aba8f391ff904785c089df7

Those changes are done just to make pre-commit hook happy.
TrivialFix
Change-Id: I8e21f41626bcd34c7ff490ea9ac6d7eb40316013

... because LF is commonly used as newline code.
Change-Id: If238971837e7732068bb935c16b2a9a160d9a9a1

None of these files need to be executable.
Change-Id: I65e80a4b2a1136558c060da46b22189c1ed50c7d

With django 4 some of the imports were changed, adopt
bgpvpn_dashboard to these changes.
Change-Id: If2728626f227a8cb4023cb2395c4c440e92347db

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: I9cf01144b3cd623856a564c8eb1048e5935fb256

In Django 3.1, django.conf.urls.url() is deprecated
in favor of django.urls.re_path(). For more info see [1]
These were already replaced in Horizon repo by [2].
[1] https://docs.djangoproject.com/en/4.0/releases/3.1/#id2
[2] https://review.opendev.org/c/openstack/horizon/+/827093
Change-Id: Id90e65ce8ad132b4518e3f979b4d7ad8917ce267

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: I4d015cfe8b97e0fc1259d47c89f4b0704accb61c

This patch is a clean-up patch for refactor-error-messages bp
which remove the exception message from base message otherwise
the same exception message display twice like
this https://ibb.co/XyFWMdz .
Depends-On: https://review.opendev.org/#/c/708069/
Change-Id: Ic7061cd293b238c497f0f4343aa3cc0e7996d5a0

Make the code compatible with hacking rules:
* import order problems
* line break before/after binary operator (for this added ignore for
W504, line break after binary operator
* indentation problems
I removed the rule N530 (Direct neutron imports not allowed), as that is
a longer story.
As a side-effect use newer pylint version, and fix the problems reported
Change-Id: I701c89ecc890a1d866815b5401cd4c022c51c9c4
Depends-On: https://review.opendev.org/#/c/708965/ 

Now that we no longer support py27, we can use the standard library
unittest.mock module instead of the third party mock lib.
Change-Id: I2cf3afe0ce833e5d85563a6b10f9ac71f3b8c485
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: I49c675d4a8bfcba05757d9e052bddde881f0beea

Horizon test setting no longer depends on nose and related stuffs.
This commit cleans up nose related dependencies.
The change was made in horizon Rocky-3,
so horizon 14.0.0.0b3 is required at least.
Filenames of test modules need to start with test_*
so that Django test runner detects them.
There is no test defined but it would be nice to adjust the filename.
Change-Id: I794e10b2c3c2c7004f7b58ff8c8904d4537a23d9

Now that mox has been removed we can remove the create_stubs
helper function as well.
Change-Id: Iec1e633c41b8b35f429ce532fc64967aa9db5b43
Signed-off-by: Chuck Short <chucks@redhat.com>

As of horizon 14.0.0.0b2 or later the use_mox directive is unecessary so we can remove it.
Change-Id: Ie2f2cdecb7893480697dafad0a9a6a96fcc54a74
Signed-off-by: Chuck Short <chucks@redhat.com>

Changes 553444 and 536899 adds new buttons and
tabs to create and delete network and router
associations.
The old way to handle the associations is
not needed anymore.
Change-Id: I856b2b5e8025fe685da78882a5c3822f88796017

Recently horizon test configuration was changed to use
the Django default test runner because nose is in maintenance mode
for the past several years [1]. Django testcase and testtools are
incompatible, so bgpvpn_dashboard testcases now fail.
In addition, bgpvpn_dashboard/test/test.py is unnecessary
and it causes the test failure too, so this file will be
dropped by this commit.
[1] horizon commit 1f80d94459856a8c477310cc0fe4b0e165d8c0c1
Change-Id: I45ff876871d7dcb82f284061b3a7225dd65c771b
Closes-Bug: #1776223 

Replaces django.core.urlresolves with django.urls.
(In Django 2.0) The django.core.urlresolvers module is removed
in favor of its new location, django.urls.
It was deprecated in Django 1.10:
https://docs.djangoproject.com/en/2.0/releases/1.10/#id3
The arguments of include() has been changed in Django 1.9
and the older style was dropped in Django 2.0.
https://docs.djangoproject.com/en/2.0/releases/1.9/#passing-a-3-tuple-or-an-app-name-to-include
Add py35dj20 job to test Django 2.0 integration.
Change-Id: I1cdfc19c9fae5cad1adac0867f65d2ae15385d87

This patch add a button "create router association" in bgpvpn panels.
It open a form to add only one network association with optionals parameters.
The bgpvpn overview details is more complete. There is
now a router associations tab which list all the router
associations. It's possible to delete each router
association and to update it.
Change-Id: Idd5af2ce2d4d864882c6191d648d16d9d9bcf35f
Partially-Implements: blueprint routes-control

This patch adds a button "create network association" in bgpvpn panels. It
opens a form to add only one network association.
The bgpvpn overview details is more complete. There is now a
network associations tab which list all the network associations. It's
possible to delete each network association. It's inspired by the network
panel which include subnets and ports tabs on the overview of a network.
It will be easier in the future to add others associations as routers and
ports with the same logical with new tab in bgpvpn overview details.
Change-Id: I6280b53558b6b52081ee6d629e8f3963d8dfc346

This change updates the call to neutronclient to use
the BGPVPN methods natively defined in python-neutronclient,
rather than the ones defined by the dynamic extension to
neutronclient from networking-bgpvpn (which are deprecated).
Also removes use of mox at the same time.
This change also makes the lower constraint job use
neutron, horizon, networking-odl and networking-bagpipe
from git, which is required to unbreak the CI right now.
Change-Id: I7d399466f6577e4dd55b1a0fa5a92aab15e6eebb
Partial-Bug: 1761691

Class BgpvpnTable between admin and project panel has
some common code. This patch inherit BgpvpnTable class
from project in BgpvpnTable Admin table.
Change-Id: I6c59f79334ef22afb8160aee44c244c6f5fc9b15

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: I47a0f8bf1b85a5b9e666e2d776dc7085a77eae63

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: I4e329194e78b59fd2ec364b24b85dfaf7a50b075

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: I42962136db49e7491bba13d374b93f1289db88b8

In the popup Update Networks Association the field network can be empty
when a network has no name. Same thing for the routers.
The fix displays the id when name doesn't exist.
Change-Id: I71d4bf3f74997a1d0bf1e84e93d88ac5c22678fc
Closes-Bug:1742948

Fix minors errors in some message information
Change-Id: Ib4e1828c3e6ca5dcfe5b0e916f239d67d5514c94

Method network_association_list was called instead
router_association_list.
Change-Id: I0418f436ff1f45ec2d7644bbf6851b24d2e180f1

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: Iad2622a3cbc9c5c3eae640eafd2fa1378f5583da

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: I1744f34c5012c5c3c4fe1b184b53569d538a0a8d

Some error messages aren't fully compatible for a
translation in an other language.
This patch change few messages to allow a better translation.
Change-Id: Iab3d470133f500eb9e9daa5996ca54c6b36be5e3

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: I15bc4cf75f909b4848f0e769c6a61ceadc9539cc

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: Ib4ce01068dc0da05e708924e7185cd3e1f3a5c9d

For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html
Change-Id: I9b5a61c8283611ff2912dcfbcd19a603eaaad6ac

The fields route targets should always been formated
even if the user is not a admin.
Check if admin is connected is useless here.
Change-Id: I9111ddc364b004ce757cdd665147df3fc23784cc
Closes-Bug: 1730678

If the route targets, import targets or export targets are empty in the
django form, the creation or modification of the bgpvpn failed.
The neutron server return a error (Invalid input for export_targets.
Reason: '' is not a valid input.)
The route_targets are not correctly formatted and a empty string is sent
instead an empty list when the fields route_targets are empty in the form.
Change-Id: I3b233f68c12795713daf6c1a00042730eea84c56
Closes-Bug: 1730678

This modification have to be done further to
change 504148. Otherwise the Regex for the
validation of Route Target is not correcty used.
Depends-On: Idb97459c6d37ce027b6fef4f15883017120095e2
Closes-Bug: 1717512
Related-Bug: 1717233
Change-Id: Ifb530ad63fed96b4447d5443d712f8fc978899ce

Unit tests for dashboard elements regarding BGP VPN.
Test dashboard elements (except workflows) only for
a admin user.
Change-Id: I5bd6b154725a60a94d98e2e64ca8fba95ec20c80

The policy check framework is added in the
devstack installation.
Documentation modified for a manuel installation.
Change-Id: I0791e329f41feca79ebe2f31321d1ce02ac44ec3

Patch 476532 has removed some lines but everything
was not removed. It's useless now to get the bgpvpn_id and
the tenant_id. These data was useful only when we were (uselessly)
checking if the name of BGPVPN was already used by an other BGPBPN.
Change-Id: I587077744968ab08b0b5b359a4ec8efa51963c34

- When a route target is incorrect in the create or update form
a popup message should indicate that validation of this field failed.
This message doesn't display and instead a generic error is returned.
It's a mistake to convert the route_target which is charfield type to
a list in the clean method.
This, need to be done after in the handle method when the datas are "cleaned".
- Fix also bad behavior when a admin user update a BGPVPN. In some cases
update doesn't work when the RT field are edited.
Closes-Bug: 1716941
Closes-Bug: 1716689
Change-Id: I5fa5a15ddf90bc2a38645c54132cc6b57e9b797a

Refactoring code of the project and admin views.py files.
Instead of calling all networks, routers and tenants
before the loop, each needed resources is called inside the loop.
Change-Id: Iae584e06dd07f2f7f128fceb9d7b8b9a2e0350b2

BGPVPN Interconnections admin panel was in system group.
This change put the BGPVPN panel in the network group.
Change-Id: I872e49c4e1aa84f328070272ae3fec014e083d1c
Closes-Bug: 1702641