Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add Symfony 7.0 to reqs and CI, drop 6.2 from CI; drop PHP 7.4 #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewmy wants to merge 44 commits into php-enqueue:master from andrewmy:add-sf70

Conversation

Copy link
Contributor

@andrewmy andrewmy commented Dec 21, 2023
edited
Loading

Let's install this on modern apps too!

Prod changes:

  • Add Symfony ^7.0 to composer requirements;
  • Add Symfony 7.0.* to CI;
  • Drop Symfony 6.2.* (EOL) from CI;
  • Drop PHP 7.4 (EOL) from composer reqs and CI.

Got some random AMQP type errors on PHP 7.4 and decided to drop it rather than fix.

PHP 8.0 is also EOL but not bothering us much for now.

Dev changes:

  • Bump localstack to v3 to accommodate for new AWS SDK which now only does SQS-JSON instead of XML;
  • Bump PHPUnit to 9.6.15;
  • Fix PHP 8.2 builds, the matrix was messed up 🙈

MaSpeng, martinssipenko, and bkosun reacted with thumbs up emoji igordeveloper reacted with heart emoji
@andrewmy andrewmy changed the title (削除) Add Symfony 7.0 to reqs and CI, drop 6.2 from CI (削除ここまで) (追記) Add Symfony 7.0 to reqs and CI, drop 6.2 from CI; drop PHP 7.4 (追記ここまで) Dec 21, 2023
Copy link

@andrewmy What is your planning with this PR?
I was started to add Symfony 7 to composer.json (#1331). But that was more impact than I expected.

Copy link
Contributor Author

andrewmy commented Jan 3, 2024
edited
Loading

@TechComBiz I see a weird failure on one SnsQs test on some matrix branches, thinking how to debug this

Copy link
Member

makasim commented Nov 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /