Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Support Symfony 7 #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexandre-daubois wants to merge 1 commit into php-enqueue:master from alexandre-daubois:sf-7

Conversation

Copy link

@alexandre-daubois alexandre-daubois commented Mar 13, 2024 •
edited
Loading

Opened this one in favor of #1326, #1328 and #1331.

The goal is to unite the work of all other PRs and debug this until we have the awaited compatibility 🙂

The only remaining failure is strange, I don't understand it:

1) Enqueue\SnsQs\Tests\Spec\SnsQsSendToTopicAndReceiveNoWaitFromQueueTest::test
Failed asserting that null is an instance of interface "Interop\Queue\Message".
/mqdev/vendor/queue-interop/queue-spec/src/SendToTopicAndReceiveNoWaitFromQueueSpec.php:50
/mqdev/pkg/test/RetryTrait.php:26

I'm having a look at it but please share any info if you have an idea 😄 But I could not find any info about SNSQS, has it been dropped? 🤔 This would explain the failure.

IlyaPokamestov reacted with thumbs up emoji amenophis and furester reacted with eyes emoji
Copy link

Hi, any news about PR?

Copy link
Author

Nothing new yet, waiting for the review 😊

dfernandes-wanadev
dfernandes-wanadev approved these changes May 22, 2024 •
edited
Loading
Copy link

Hi, any move here? Can I help with something?

Copy link
Author

alexandre-daubois commented Jun 11, 2024 •
edited
Loading

Unfortunately, Symfony 7 has been out now for 7-8 months so we decided to switch to
petitpress/gps-messenger-bundle (as we only use the Google Pubsub part of enqueue, it was just a matter of DSN updating). I still hope this PR gets merged/reviewed at some point for all the other projects out there that rely on Enqueue, but for our case, we sadly had to find another package to keep up with Symfony release process 😕

Copy link
Member

makasim commented Nov 18, 2024

#1362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@IlyaPokamestov IlyaPokamestov IlyaPokamestov left review comments

@dfernandes-wanadev dfernandes-wanadev dfernandes-wanadev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /