Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add Symfony 7.0 to reqs and CI, drop 6.2 from CI; drop PHP 7.4 #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewmy wants to merge 44 commits into php-enqueue:master from andrewmy:add-sf70
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
847eca8
Add Symfony 7.0 to reqs and CI, drop 6.2 from CI
andrewmy Dec 21, 2023
6814e1d
Cast to int to avoid type errors — probably the new extension forces ...
andrewmy Dec 21, 2023
9d4b80d
Skip PHP 8.1 on Symfony 7.0 in the CI matrix
andrewmy Dec 21, 2023
f0a0ae7
Fix CS
andrewmy Dec 21, 2023
90b6b56
Try with doctrine/mongodb-odm-bundle:5.0.x-dev
andrewmy Dec 21, 2023
48d4fea
Fix ext-mongo override
andrewmy Dec 21, 2023
b5ef96e
Remove usage of deprecated ContainerAware
andrewmy Dec 21, 2023
fd6a9b6
Fix CS
andrewmy Dec 21, 2023
e99fac7
Fix config type error?
andrewmy Dec 21, 2023
e9bad64
Fix CS
andrewmy Dec 21, 2023
e910537
Fix doctrine/annotations:2 compatibility
andrewmy Dec 21, 2023
3b41306
Fix CS 🤦
andrewmy Dec 21, 2023
eda3d7d
Drop PHP 7.4 🔥
andrewmy Dec 21, 2023
dd3168c
Fix CS
andrewmy Dec 21, 2023
f9b26f2
Force older AWS SDK version to avoid SQS-JSON requirement
andrewmy Dec 28, 2023
401396c
Try with localstack v3
andrewmy Dec 28, 2023
4cf175d
Re-run please
andrewmy Dec 28, 2023
eff6293
Update localstack env var
andrewmy Dec 28, 2023
92ede9f
Update localstack ports
andrewmy Dec 28, 2023
b00b53e
Fix the matrix 🤦
andrewmy Dec 28, 2023
14ac0b6
Refactor doctrine entity annotations into attributes
andrewmy Dec 28, 2023
45b2eb4
Refactor doctrine entity mapping into XML — compatible in both lowest...
andrewmy Dec 28, 2023
603b9b4
Backwards-compatible SQS endpoints pls
andrewmy Dec 28, 2023
c14d383
Derp
andrewmy Dec 28, 2023
bc5db65
Fix mapping in tests
andrewmy Dec 28, 2023
6f6d9b2
Fix table names
andrewmy Dec 28, 2023
74b6dc7
Bump phpunit to 9.6.15
andrewmy Dec 28, 2023
5aaab0c
Fix deprecation
andrewmy Dec 28, 2023
313a569
Re-run please
andrewmy Dec 28, 2023
5341f51
Fix CS
andrewmy Dec 28, 2023
f2b6241
Fix more deprecations
andrewmy Dec 28, 2023
bfc1d65
Fix CS
andrewmy Dec 28, 2023
169c9e3
Fix newer sf compat
andrewmy Dec 28, 2023
3bf83cf
Bump amqplib to avoid deprecations
andrewmy Dec 28, 2023
462660c
Fix CS, bump cs-fixer
andrewmy Dec 29, 2023
1df3087
Try sleeping?
andrewmy Dec 29, 2023
4e1f44d
One more deprecation
andrewmy Dec 29, 2023
0834598
Fix CS
andrewmy Dec 29, 2023
4eb3b57
Fix a deprecation
andrewmy Jan 3, 2024
7f5ad73
Try eager localstack service loading
andrewmy Jan 3, 2024
b031bca
Move the sleep
andrewmy Jan 3, 2024
ffec2be
Run the CI again
andrewmy Apr 4, 2024
c7d74b5
Fix CS
andrewmy Apr 4, 2024
cbabc23
Launch localstack with debug
andrewmy Apr 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix CS
  • Loading branch information
andrewmy committed Apr 4, 2024
commit c7d74b5f7b13ec6c405760a8b88e08b996b5fbdf
6 changes: 3 additions & 3 deletions pkg/amqp-bunny/AmqpProducer.php
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public function send(Destination $destination, Message $message): void
/**
* @return self
*/
public function setDeliveryDelay(int $deliveryDelay = null): Producer
public function setDeliveryDelay(?int $deliveryDelay = null): Producer
{
if (null === $this->delayStrategy) {
throw DeliveryDelayNotSupportedException::providerDoestNotSupportIt();
Expand All @@ -98,7 +98,7 @@ public function getDeliveryDelay(): ?int
/**
* @return self
*/
public function setPriority(int $priority = null): Producer
public function setPriority(?int $priority = null): Producer
{
$this->priority = $priority;

Expand All @@ -113,7 +113,7 @@ public function getPriority(): ?int
/**
* @return self
*/
public function setTimeToLive(int $timeToLive = null): Producer
public function setTimeToLive(?int $timeToLive = null): Producer
{
$this->timeToLive = $timeToLive;

Expand Down
2 changes: 1 addition & 1 deletion pkg/amqp-ext/AmqpConsumer.php
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public function __construct(AmqpContext $context, InteropAmqpQueue $queue)
$this->flags = self::FLAG_NOPARAM;
}

public function setConsumerTag(string $consumerTag = null): void
public function setConsumerTag(?string $consumerTag = null): void
{
$this->consumerTag = $consumerTag;
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/async-event-dispatcher/ContainerAwareRegistry.php
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public function __construct(array $eventsMap, array $transformersMap)
$this->transformersMap = $transformersMap;
}

public function setContainer(ContainerInterface $container = null)
public function setContainer(?ContainerInterface $container = null)
{
$this->container = $container;
}
Expand Down
17 changes: 10 additions & 7 deletions pkg/job-queue/Tests/Functional/app/AppKernel.php
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,23 @@
<?php

// doctrine/annotations:2 autoloads annotations and removes loader registration
if (method_exists(\Doctrine\Common\Annotations\AnnotationRegistry::class, 'registerLoader')) {
\Doctrine\Common\Annotations\AnnotationRegistry::registerLoader('class_exists');
}

use Doctrine\Bundle\DoctrineBundle\DoctrineBundle;
use Doctrine\Common\Annotations\AnnotationRegistry;
use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
use Symfony\Component\Config\Loader\LoaderInterface;
use Symfony\Component\HttpKernel\Kernel;

// doctrine/annotations:2 autoloads annotations and removes loader registration
if (method_exists(AnnotationRegistry::class, 'registerLoader')) {
AnnotationRegistry::registerLoader('class_exists');
}

class AppKernel extends Kernel
{
public function registerBundles(): iterable
{
$bundles = [
new \Symfony\Bundle\FrameworkBundle\FrameworkBundle(),
new \Doctrine\Bundle\DoctrineBundle\DoctrineBundle(),
new FrameworkBundle(),
new DoctrineBundle(),
];

return $bundles;
Expand Down
4 changes: 2 additions & 2 deletions pkg/snsqs/Tests/Spec/SnsQsFactoryTrait.php
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ protected function createSnsQsContext(): SnsQsContext

protected function createSnsQsQueue(string $queueName): SnsQsQueue
{
$queueName = $queueName.time();
$queueName .= time();

$this->snsQsQueue = $this->snsQsContext->createQueue($queueName);
$this->snsQsContext->declareQueue($this->snsQsQueue);
Expand All @@ -52,7 +52,7 @@ protected function createSnsQsQueue(string $queueName): SnsQsQueue

protected function createSnsQsTopic(string $topicName): SnsQsTopic
{
$topicName = $topicName.time();
$topicName .= time();

$this->snsQsTopic = $this->snsQsContext->createTopic($topicName);
$this->snsQsContext->declareTopic($this->snsQsTopic);
Expand Down

AltStyle によって変換されたページ (->オリジナル) /