Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: extract OpenEditor into internal/editor, out of the TUI package#1242

Open
jonnii wants to merge 1 commit into
jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from from
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of
Open

refactor: extract OpenEditor into internal/editor, out of the TUI package #1242
jonnii wants to merge 1 commit into
jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from from
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of

Conversation

@jonnii

@jonnii jonnii commented Jun 16, 2026
edited
Loading

Copy link
Copy Markdown
Collaborator

tui.OpenEditor is exec-based (launches $EDITOR on a temp file) — it has no
Bubble Tea dependency and was only in internal/tui by accident of placement.
Move it to a new lightweight internal/editor package (editor.Open) so callers
that just need an editor don't pull in the heavy TUI package.

Also move the small interactivity helpers it needs — CheckInteractiveAllowed
and ErrInteractiveDisabled — down to internal/utils (next to IsInteractive),
and re-export them from internal/tui so existing tui callers and errors.Is
checks are unchanged (same error var).

Updates all five OpenEditor call sites. create/message and describe now have
no internal/tui import at all (12 -> 10 tui-importing action files);
reorder, submit_metadata, and the split CLI handler keep tui for their
genuine Bubble Tea prompts. Behavior preserved (lint, tui/utils unit tests,
integration 494).


Stack

Auto-generated by Stackit

@jonnii jonnii force-pushed the jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of branch from 84fd7a2 to fc960f1 Compare June 17, 2026 01:51
@jonnii jonnii changed the base branch from jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from to main June 17, 2026 01:51
@jonnii jonnii changed the base branch from main to jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from June 17, 2026 01:51
@jonnii jonnii changed the base branch from jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from to main June 19, 2026 19:28
@jonnii jonnii force-pushed the jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of branch from fc960f1 to 5df6aad Compare June 19, 2026 19:28
@jonnii jonnii changed the base branch from main to jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from June 19, 2026 19:28
...kage
tui.OpenEditor is exec-based (launches $EDITOR on a temp file) — it has no
Bubble Tea dependency and was only in internal/tui by accident of placement.
Move it to a new lightweight internal/editor package (editor.Open) so callers
that just need an editor don't pull in the heavy TUI package.
Also move the small interactivity helpers it needs — CheckInteractiveAllowed
and ErrInteractiveDisabled — down to internal/utils (next to IsInteractive),
and re-export them from internal/tui so existing tui callers and errors.Is
checks are unchanged (same error var).
Updates all five OpenEditor call sites. create/message and describe now have
no internal/tui import at all (12 -> 10 tui-importing action files);
reorder, submit_metadata, and the split CLI handler keep tui for their
genuine Bubble Tea prompts. Behavior preserved (lint, tui/utils unit tests,
integration 494).
@jonnii jonnii force-pushed the jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of branch from 5df6aad to cc86016 Compare June 23, 2026 02:14
@jonnii jonnii changed the base branch from jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from to main June 23, 2026 02:14
@jonnii jonnii changed the base branch from main to jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from June 23, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /