-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: extract OpenEditor into internal/editor, out of the TUI package#1242
Open
Conversation
This was referenced Jun 16, 2026
@jonnii
jonnii
force-pushed
the
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of
branch
from
June 17, 2026 01:51
84fd7a2 to
fc960f1
Compare
@jonnii
jonnii
changed the base branch from
jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from
to
main
June 17, 2026 01:51
@jonnii
jonnii
changed the base branch from
main
to
jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from
June 17, 2026 01:51
@jonnii
jonnii
changed the base branch from
jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from
to
main
June 19, 2026 19:28
@jonnii
jonnii
force-pushed
the
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of
branch
from
June 19, 2026 19:28
fc960f1 to
5df6aad
Compare
@jonnii
jonnii
changed the base branch from
main
to
jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from
June 19, 2026 19:28
...kage tui.OpenEditor is exec-based (launches $EDITOR on a temp file) — it has no Bubble Tea dependency and was only in internal/tui by accident of placement. Move it to a new lightweight internal/editor package (editor.Open) so callers that just need an editor don't pull in the heavy TUI package. Also move the small interactivity helpers it needs — CheckInteractiveAllowed and ErrInteractiveDisabled — down to internal/utils (next to IsInteractive), and re-export them from internal/tui so existing tui callers and errors.Is checks are unchanged (same error var). Updates all five OpenEditor call sites. create/message and describe now have no internal/tui import at all (12 -> 10 tui-importing action files); reorder, submit_metadata, and the split CLI handler keep tui for their genuine Bubble Tea prompts. Behavior preserved (lint, tui/utils unit tests, integration 494).
@jonnii
jonnii
force-pushed
the
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of
branch
from
June 23, 2026 02:14
5df6aad to
cc86016
Compare
@jonnii
jonnii
changed the base branch from
jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from
to
main
June 23, 2026 02:14
@jonnii
jonnii
changed the base branch from
main
to
jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from
June 23, 2026 02:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
tui.OpenEditor is exec-based (launches $EDITOR on a temp file) — it has no
Bubble Tea dependency and was only in internal/tui by accident of placement.
Move it to a new lightweight internal/editor package (editor.Open) so callers
that just need an editor don't pull in the heavy TUI package.
Also move the small interactivity helpers it needs — CheckInteractiveAllowed
and ErrInteractiveDisabled — down to internal/utils (next to IsInteractive),
and re-export them from internal/tui so existing tui callers and errors.Is
checks are unchanged (same error var).
Updates all five OpenEditor call sites. create/message and describe now have
no internal/tui import at all (12 -> 10 tui-importing action files);
reorder, submit_metadata, and the split CLI handler keep tui for their
genuine Bubble Tea prompts. Behavior preserved (lint, tui/utils unit tests,
integration 494).
Stack
Auto-generated by Stackit