-
Notifications
You must be signed in to change notification settings - Fork 1
refactor(actions): take rename's prompt off the TUI; drop tui from restack#1164
Open
jonnii wants to merge 1 commit into
Open
refactor(actions): take rename's prompt off the TUI; drop tui from restack #1164jonnii wants to merge 1 commit into
jonnii wants to merge 1 commit into
Conversation
@jonnii
jonnii
force-pushed
the
jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from
branch
from
June 16, 2026 10:34
426fc3d to
f4ea451
Compare
This was referenced Jun 16, 2026
@jonnii
jonnii
force-pushed
the
jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from
branch
2 times, most recently
from
June 19, 2026 19:28
1e369e5 to
12f27df
Compare
...stack Two small, self-contained steps toward keeping interactive/TUI concerns out of the action layer: - rename: RenameAction took the new branch name by calling tui.PromptTextInput directly. Introduce a RenameHandler interface (PromptNewName) that the action calls when no name is given; the CLI command supplies a TUI-backed implementation that also owns the non-interactive guard. The action no longer imports internal/tui. - restack: the only tui use was tui.IsTTY(), which is a pure re-export of utils.IsTTY(). Call utils.IsTTY() directly and drop the tui import. Both are behavior-preserving (verified by lint, cli, and integration suites). These were the only two action files whose tui use was trivially extractable; the rest drive real select/editor/bubbletea UIs and need per-action prompter interfaces.
@jonnii
jonnii
force-pushed
the
jonnii/20260605031052/take-rename-s-prompt-off-the-TUI-drop-tui-from
branch
from
June 23, 2026 02:14
12f27df to
86ccbdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Two small, self-contained steps toward keeping interactive/TUI concerns out
of the action layer:
rename: RenameAction took the new branch name by calling tui.PromptTextInput
directly. Introduce a RenameHandler interface (PromptNewName) that the action
calls when no name is given; the CLI command supplies a TUI-backed
implementation that also owns the non-interactive guard. The action no longer
imports internal/tui.
restack: the only tui use was tui.IsTTY(), which is a pure re-export of
utils.IsTTY(). Call utils.IsTTY() directly and drop the tui import.
Both are behavior-preserving (verified by lint, cli, and integration suites).
These were the only two action files whose tui use was trivially extractable;
the rest drive real select/editor/bubbletea UIs and need per-action prompter
interfaces.
Stack
Auto-generated by Stackit