-
Notifications
You must be signed in to change notification settings - Fork 1
refactor(create): route insert's child-select prompt through the Handler#1241
Open
Conversation
This was referenced Jun 16, 2026
@jonnii
jonnii
force-pushed
the
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of
branch
from
June 17, 2026 01:51
84fd7a2 to
fc960f1
Compare
@jonnii
jonnii
changed the base branch from
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of
to
main
June 17, 2026 01:51
@jonnii
jonnii
force-pushed
the
jonnii/20260605033020/route-insert-s-child-select-prompt-through-the
branch
from
June 17, 2026 01:51
2b26158 to
e62efd4
Compare
@jonnii
jonnii
changed the base branch from
main
to
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of
June 17, 2026 01:51
@jonnii
jonnii
changed the base branch from
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of
to
main
June 19, 2026 19:28
@jonnii
jonnii
force-pushed
the
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of
branch
from
June 19, 2026 19:28
fc960f1 to
5df6aad
Compare
@jonnii
jonnii
force-pushed
the
jonnii/20260605033020/route-insert-s-child-select-prompt-through-the
branch
from
June 19, 2026 19:28
e62efd4 to
92604ba
Compare
@jonnii
jonnii
changed the base branch from
main
to
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of
June 19, 2026 19:28
@jonnii
jonnii
force-pushed
the
jonnii/20260605033020/route-insert-s-child-select-prompt-through-the
branch
from
June 23, 2026 02:14
92604ba to
b27a76b
Compare
@jonnii
jonnii
force-pushed
the
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of
branch
from
June 23, 2026 02:14
5df6aad to
cc86016
Compare
@jonnii
jonnii
changed the base branch from
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of
to
main
June 23, 2026 02:14
@jonnii
jonnii
changed the base branch from
main
to
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of
June 23, 2026 02:14
handleInsert prompted the user (tui.PromptSelect) to choose which child branch to move onto a newly inserted branch — importing internal/tui into the action layer. create already has a Handler with prompt methods (PromptStageChanges, PromptScope) implemented by the CLI handlers, so add a PromptChildToMove(children) method the same way: - create.Handler + NullHandler gain PromptChildToMove (null returns "all"). - The CLI SimpleCreateHandler returns "all"; InteractiveCreateHandler builds the select options and calls tui.PromptSelect. - handleInsert takes the handler and calls h.PromptChildToMove, gated on h.IsInteractive() (replacing the inline utils.IsInteractive + tui usage). create/insert.go no longer imports internal/tui or internal/utils (now 9 tui-importing action files). Behavior preserved (lint, create unit tests, integration 494).
@jonnii
jonnii
changed the base branch from
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of
to
main
June 24, 2026 02:38
@jonnii
jonnii
force-pushed
the
jonnii/20260605033020/route-insert-s-child-select-prompt-through-the
branch
2 times, most recently
from
June 24, 2026 02:38
b27a76b to
7ed395c
Compare
@jonnii
jonnii
changed the base branch from
main
to
jonnii/20260605032227/extract-OpenEditor-into-internal/editor-out-of
June 24, 2026 02:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
handleInsert prompted the user (tui.PromptSelect) to choose which child
branch to move onto a newly inserted branch — importing internal/tui into
the action layer. create already has a Handler with prompt methods
(PromptStageChanges, PromptScope) implemented by the CLI handlers, so add a
PromptChildToMove(children) method the same way:
the select options and calls tui.PromptSelect.
h.IsInteractive() (replacing the inline utils.IsInteractive + tui usage).
create/insert.go no longer imports internal/tui or internal/utils (now
9 tui-importing action files). Behavior preserved (lint, create unit tests,
integration 494).
Stack
Auto-generated by Stackit