Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Hide OSD (SD) settings #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haslinghuis merged 1 commit into betaflight:master from atomgomba:hide-osd-sd-settings
Mar 23, 2024

Conversation

Copy link
Contributor

@atomgomba atomgomba commented Jan 24, 2024

Follow up PR on #495. Please merge #495 first, because it contains the parent commit.

Copy link
Contributor Author

It looks like on some boards getting the OSD config may take a lot of time over CRSF

Copy link

Tested and everything seems to work.

Imo a rebase is still missing here.

Copy link
Contributor Author

atomgomba commented Jan 25, 2024
edited
Loading

Tested and everything seems to work.

Imo a rebase is still missing here.

Seemingly it doesn't always work for me. I tested using 4 different quads. My radio is Tango 2 with FreedomTX, what's your radio and firmware? I'm starting to feel like I'm gonna need more hardware for testing. I can get a Micro TX for my Taranis X9D+ (has EdgeTX on it) to have one more test device.

Copy link

I use the RM Zorro with EdgeTX for FrSky and Ghost receivers.

Copy link
Contributor Author

With #13333 we're slowly getting to the point where firing a single MSP request to get the supported options will be enough. Waiting for multiple responses takes inconveniently lot amount of time, I'm planning to put this PR on hold until we have a better way to check build options.

@atomgomba atomgomba force-pushed the hide-osd-sd-settings branch 5 times, most recently from 667132c to 5b8891e Compare February 2, 2024 17:13
Copy link
Member

With #13333 we're slowly getting to the point where firing a single MSP request to get the supported options will be enough. Waiting for multiple responses takes inconveniently lot amount of time, I'm planning to put this PR on hold until we have a better way to check build options.

This is probably the best solution. I think we should put everything else on hold just to avoid ending up with multiple solutions and compatibility issues. We have three solutions to this right now, and we should pick just one.
I'm not sure which protocol you're testing this with, but the worst case scenario is FPORT as it's super slow.

Copy link
Contributor Author

With #13333 we're slowly getting to the point where firing a single MSP request to get the supported options will be enough. Waiting for multiple responses takes inconveniently lot amount of time, I'm planning to put this PR on hold until we have a better way to check build options.

This is probably the best solution. I think we should put everything else on hold just to avoid ending up with multiple solutions and compatibility issues. We have three solutions to this right now, and we should pick just one. I'm not sure which protocol you're testing this with, but the worst case scenario is FPORT as it's super slow.

Currently I've only tested on CRSF, but on two "different" platforms, FreedomTX and EdgeTX. I happen to own an X9D+ and FrSky receivers so with a bit of soldering I can test FPORT too. Thanks for the heads up!

klutvott123 reacted with thumbs up emoji

Copy link
Contributor Author

atomgomba commented Feb 4, 2024
edited
Loading

New plan is to have a dedicated MSP command for clients using OTA transmission, please see #13344

EDIT: Above PR #13344 had been dropped, will go ahead with #13333 instead

Copy link
Contributor Author

This is not stale, just waiting for #13333 to be merged. I presume it's most likely to happen after 4.5 release.

@atomgomba atomgomba marked this pull request as ready for review March 22, 2024 14:13
Copy link
Member

@TheIsotopes pls test again :) (needs latest dev firmware)

Copy link
Contributor Author

@TheIsotopes pls test again :) (needs latest dev firmware)

well, it's only needed to test the happy path. by design the menu will load either way ;) btw I also tested this, but more tests the better. testing against MSP version <= 1.46 is a real scenario as well. so far I haven't tested against BF 4.4, but I'm planning to do so in the weekend

haslinghuis reacted with rocket emoji

Copy link

@atomgomba @haslinghuis
tested on my Zorro, everything seems to be working correctly for me. 👍

haslinghuis reacted with hooray emoji

Copy link
Contributor Author

tested on 4.4.3, works as expected

@haslinghuis haslinghuis merged commit de29b66 into betaflight:master Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /