Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on May 25, 2022. It is now read-only.

Recursive password generator And Tic Tac Toe #180

Merged
AdityaJ7 merged 8 commits into Python-World:master from erfansaberi:patch-1
Sep 7, 2020
Merged

Recursive password generator And Tic Tac Toe #180

AdityaJ7 merged 8 commits into Python-World:master from erfansaberi:patch-1
Sep 7, 2020

Conversation

Copy link
Contributor

@erfansaberi erfansaberi commented Sep 5, 2020

Take a look at this, it's a recursive random password generator, and also simple.

Copy link
Member

@chavarera chavarera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erfansaberi code is working fine

can you print password in proper manner

[?] Enter a length for your password: 20
(' [+]', 'i&U1YSXxj0#lg$gjKZmP', '\n')

Suggested Output

[?] Enter a length for your password: 20
'i&U1YSXxj0#lg$gjKZmP'

erfansaberi reacted with thumbs up emoji
Copy link
Contributor Author

Good idea 👌

Copy link
Member

@chavarera chavarera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erfansaberi

[?] Enter a length for your password: 20
("'", 'AD??y1T2hz227A#xdjdP', "'\n")

remove the other stuffs put only password

erfansaberi reacted with thumbs up emoji
@AdityaJ7 AdityaJ7 self-requested a review September 6, 2020 10:25
Copy link
Member

@AdityaJ7 AdityaJ7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a condition to check that the user enters only integer values for the length so that it prevents your program from breaking.
The program is currently in an infinite loop so add some option like if the user types exit, the program will end.
Else everything is good

erfansaberi reacted with thumbs up emoji
Copy link
Contributor Author

@AdityaJ7 you're right, i added your suggested features.

@erfansaberi erfansaberi changed the title (削除) Recursive password generator (削除ここまで) (追記) Recursive password generator And Tic Tac Toe (追記ここまで) Sep 6, 2020
Copy link
Contributor Author

I have added tic tac toe (it was appended to this pull request automaticaly)

Copy link
Member

AdityaJ7 commented Sep 6, 2020

I have added tic tac toe (it was appended to this pull request automaticaly)

The tic tac toe is working fine but your password generator is still in an infinite loop and the program does not ends on typing e

erfansaberi reacted with thumbs up emoji

Copy link
Member

@chavarera chavarera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erfansaberi

you can use builtin function of string to create

 chars = 'abcdefghijklmnopqrstuvwxyz1234567890ABCDEFGHIJKLMNOPQRSTUVWXYZ!@#$%^&*?'

better way to define same thing using string.printable

import string
chars = string.printable

this will give you extra special character which can be useful for creating password

AdityaJ7 and erfansaberi reacted with thumbs up emoji
Copy link
Contributor Author

@chavarera Yes, it cleans the code.

Copy link
Contributor Author

@AdityaJ7 I have changed the exit point, take a look at it.

Copy link
Member

AdityaJ7 commented Sep 6, 2020

@AdityaJ7 I have changed the exit point, take a look at it.

Yes, it works fine now. Good work

erfansaberi reacted with heart emoji

@AdityaJ7 AdityaJ7 merged commit a2302ba into Python-World:master Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@chavarera chavarera chavarera left review comments

@AdityaJ7 AdityaJ7 AdityaJ7 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /