Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on May 25, 2022. It is now read-only.

Add Tic Tac Toe with AI to projects. #192

Merged
AdityaJ7 merged 5 commits into Python-World:master from tusharnankani:master
Sep 8, 2020
Merged

Add Tic Tac Toe with AI to projects. #192

AdityaJ7 merged 5 commits into Python-World:master from tusharnankani:master
Sep 8, 2020

Conversation

Copy link
Member

@tusharnankani tusharnankani commented Sep 7, 2020

Description

  • This PR closes issue Create tic tac toe game #166
  • This is a terminal-based TIC TAC TOE GAME
  • It includes:
    • 1 player mode, Artificial Intelligence added, can be played with the computer;
    • 2 player mode - 2 players sitting on the same computer.;
    • AI vs. AI (for fun)

Fixes #166

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull request

  • I have named my files and folder according to this project's guidelines
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have included a requirements.txt file(if external libraries are required)
  • My changes don't produce any warnings.
  • I have added a working sample/screenshot of the script

Note:

@AdityaJ7 AdityaJ7 self-requested a review September 7, 2020 08:36
Copy link
Member

@AdityaJ7 AdityaJ7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues:

  1. The option no one that is player vs player is behaving like computer vs computer.
  2. The message showed when some position is chosen always shows the second player while it should be alternate players this issue is present in all the three cases.

User Vs AI

Capture

User 1 vs User 2

Capture2

AI vs AI

Capture3

Copy link
Member Author

Hi @AdityaJ7

I have fixed the issues now!

AdityaJ7 reacted with thumbs up emoji

Copy link
Member

@AdityaJ7 AdityaJ7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now, Good job!!

@AdityaJ7 AdityaJ7 merged commit d9890e4 into Python-World:master Sep 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@AdityaJ7 AdityaJ7 AdityaJ7 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create tic tac toe game

AltStyle によって変換されたページ (->オリジナル) /