WIP: internationalisation #57

caesar commented 2023年01月14日 11:16:08 +01:00

I started work on this a couple of weeks back and haven't had the time to come back to it. I'm pushing it here so people can give input or potentially someone else can continue work on it if I don't get time. (But let me know so we don't duplicate work.)

The locale JSON files are supposed to be compatible with Weblate.

I don't think it will make sense to use Weblate for long-form text (blog posts etc), but I haven't tried yet.

I should also apologise for what I'm sure are horrible Spanish translations, I just needed some placeholder translations 😆

I started work on this a couple of weeks back and haven't had the time to come back to it. I'm pushing it here so people can give input or potentially someone else can continue work on it if I don't get time. (But let me know so we don't duplicate work.) The locale JSON files are supposed to be compatible with Weblate. I don't think it will make sense to use Weblate for long-form text (blog posts etc), but I haven't tried yet. I should also apologise for what I'm sure are horrible Spanish translations, I just needed some placeholder translations 😆

fsologureng commented 2023年01月14日 23:12:08 +01:00

I promise to do a Spanish review asap. But i think is enough for now if you want merge it.
Now I am out of pc.

I promise to do a Spanish review asap. But i think is enough for now if you want merge it. Now I am out of pc.

caesar commented 2023年01月15日 12:21:07 +01:00

Thanks @fsologureng , it's far from being ready to merge anyway so I'm sure there'll be time for you to contribute to a proper Spanish localisation. I haven't even internationalised all the strings yet anyway, nor set up weblate, so there's a long way to go.

Thanks @fsologureng , it's far from being ready to merge anyway so I'm sure there'll be time for you to contribute to a proper Spanish localisation. I haven't even internationalised all the strings yet anyway, nor set up weblate, so there's a long way to go.

fsologureng commented 2023年01月16日 17:55:37 +01:00

There is an agreement about reader treatment? 2nd person or 3rd person?
you can be translated to Spanish as 2nd person or 3rd person in some contexts.

(I put this comment initially in other issue totally unrelated, merging desktop windows XD)

There is an agreement about reader treatment? 2nd person or 3rd person? `you` can be translated to Spanish as 2nd person or 3rd person in some contexts. (I put this comment initially in other issue totally unrelated, merging desktop windows XD)

fsologureng commented 2023年01月16日 18:08:50 +01:00

@caesar, I tried a PR to your fork but couldn't :/ fsologureng/website@2c983503f2

@caesar, I tried a PR to your fork but couldn't :/ https://codeberg.org/fsologureng/website/commit/2c983503f28172505f125533771dbbc0cc37c9a6

caesar commented 2023年01月16日 20:34:58 +01:00

@fsologureng that's strange, what happens when you try to create the PR?
Anyway I can pull your commit directly and merge it locally, no problem. Thanks for the corrections.

There is an agreement about reader treatment? 2nd person or 3rd person?
you can be translated to Spanish as 2nd person or 3rd person in some contexts.

In English there's only one option, second person.

For other languages I think it's a per-language choice depending on language conventions. Of course a regional choice could also make sense but I'm not sure if we really need regional localisations at this point.

• In Spanish for example I suppose you are referring to "usted", the formal "you" which takes third-person singular conjugations of verbs. In the case of Spanish my feeling is to stick with the informal "tu", though obviously the opinions of native speakers such as yourself are more relevant.

• Portuguese is another interesting case, where there is a major regional difference: In Brazil, "você" is used as the primary second-person pronoun but it takes third-person verb conjugations. In Portugal on the other hand "tu" is used which takes second-person verb conjugations.

• French is another interesting case. My French is poor, so @dachary should correct me if I'm wrong, but I understand that their second -person singular formal pronoun "vous" is identical to the second-person plural and takes second-person plural verb conjugations.

For all these reasons it's not an easy thing to have a generic rule about that would apply to all locales.

That said, my own feeling is we should tend towards informal rather than formal, but there may be locales where this is not appropriate.

@fsologureng that's strange, what happens when you try to create the PR? Anyway I can pull your commit directly and merge it locally, no problem. Thanks for the corrections. > There is an agreement about reader treatment? 2nd person or 3rd person? > `you` can be translated to Spanish as 2nd person or 3rd person in some contexts. In English there's only one option, second person. For other languages I think it's a per-language choice depending on language conventions. Of course a regional choice could also make sense but I'm not sure if we really need regional localisations at this point. - In Spanish for example I suppose you are referring to "usted", the formal "you" which takes third-person singular conjugations of verbs. In the case of Spanish my feeling is to stick with the informal "tu", though obviously the opinions of native speakers such as yourself are more relevant. - Portuguese is another interesting case, where there is a major regional difference: In Brazil, "você" is used as the primary second-person pronoun but it takes third-person verb conjugations. In Portugal on the other hand "tu" is used which takes second-person verb conjugations. - French is another interesting case. My French is poor, so @dachary should correct me if I'm wrong, but I understand that their second -person singular formal pronoun "vous" is identical to the second-person *plural* and takes second-person plural verb conjugations. For all these reasons it's not an easy thing to have a generic rule about that would apply to all locales. That said, my own feeling is we should tend towards informal rather than formal, but there may be locales where this is not appropriate.

fsologureng commented 2023年01月16日 20:44:24 +01:00

@fsologureng that's strange, what happens when you try to create the PR?
Anyway I can pull your commit directly and merge it locally, no problem. Thanks for the corrections.

$ git push caesar-origin HEAD
Enumerando objetos: 15, listo.
Contando objetos: 100% (15/15), listo.
Compresión delta usando hasta 8 hilos
Comprimiendo objetos: 100% (8/8), listo.
Escribiendo objetos: 100% (9/9), 2.26 KiB | 2.26 MiB/s, listo.
Total 9 (delta 5), reusados 0 (delta 0), pack-reusados 0
remote: 
remote: Gitea: User permission denied for writing.
To codeberg.org:caesar/forgejo-website.git
 ! [remote rejected] HEAD -> wip-i18n (pre-receive hook declined)
error: falló el push de algunas referencias a 'codeberg.org:caesar/forgejo-website.git'

It is very likely that I am doing something wrong. I'm improving my git skills but they are still insufficient for everything :)

> @fsologureng that's strange, what happens when you try to create the PR? > Anyway I can pull your commit directly and merge it locally, no problem. Thanks for the corrections. ~~~ $ git push caesar-origin HEAD Enumerando objetos: 15, listo. Contando objetos: 100% (15/15), listo. Compresión delta usando hasta 8 hilos Comprimiendo objetos: 100% (8/8), listo. Escribiendo objetos: 100% (9/9), 2.26 KiB | 2.26 MiB/s, listo. Total 9 (delta 5), reusados 0 (delta 0), pack-reusados 0 remote: remote: Gitea: User permission denied for writing. To codeberg.org:caesar/forgejo-website.git ! [remote rejected] HEAD -> wip-i18n (pre-receive hook declined) error: falló el push de algunas referencias a 'codeberg.org:caesar/forgejo-website.git' ~~~ It is very likely that I am doing something wrong. I'm improving my git skills but they are still insufficient for everything :)

fsologureng commented 2023年01月16日 20:51:29 +01:00

@dachary: in case you feel comfortable to share your opinion, I have created a dedicated issue to comment on the topic #66.

@dachary: in case you feel comfortable to share your opinion, I have created a dedicated issue to comment on the topic #66.

caesar commented 2023年01月16日 20:51:58 +01:00

Ah, you're pushing directly to this branch in my fork, rather than sending a PR. I hadn't enabled that, but now it's enabled so you should be able to do that.

Ah, you're pushing directly to this branch in my fork, rather than sending a PR. I hadn't enabled that, but now it's enabled so you should be able to do that.

fsologureng commented 2023年01月17日 00:53:35 +01:00

Ah, you're pushing directly to this branch in my fork, rather than sending a PR. I hadn't enabled that, but now it's enabled so you should be able to do that.

ups, that was not the idea :/

And I am not allowed to open PR neither (button disabled).

> Ah, you're pushing directly to this branch in my fork, rather than sending a PR. I hadn't enabled that, but now it's enabled so you should be able to do that. ups, that was not the idea :/ And I am not allowed to open PR neither (button disabled).

fsologureng commented 2023年01月17日 15:34:59 +01:00

Ah, you're pushing directly to this branch in my fork, rather than sending a PR. I hadn't enabled that, but now it's enabled so you should be able to do that.

I did it and it shows a CI commit not merged to the branch, is that the problem? I preferred not to do anything else.

> Ah, you're pushing directly to this branch in my fork, rather than sending a PR. I hadn't enabled that, but now it's enabled so you should be able to do that. I did it and it shows a CI commit not merged to the branch, is that the problem? I preferred not to do anything else.

caesar commented 2023年01月19日 08:13:07 +01:00

It seems fine to me @fsologureng, I am seeing the commit in the Git tree correctly.

Good idea to also cherry-pick the CI branch preview commit. I assume this PR can now be previewed at https://forgejo.codeberg.page/@pull_57/, but Codeberg Pages seems to be down at the moment so I can't check.

It seems fine to me @fsologureng, I am seeing the commit in the Git tree correctly. Good idea to also cherry-pick the CI branch preview commit. I assume this PR can now be previewed at https://forgejo.codeberg.page/@pull_57/, but Codeberg Pages seems to be down at the moment so I can't check.

earl-warren commented 2024年04月21日 10:34:19 +02:00

closing as very out dated

closing as very out dated