1lab/mikan
13
52
Fork
You've already forked mikan
9

feat: make instance search errors non-fatal #128

Merged
amyliao merged 1 commit from pounce/mikan:nonfatal-search into main 2026年06月18日 14:22:46 +02:00
Contributor
Copy link

this change depends on #122.

thanks @amyliao for the mentorship on this one!

resolves: #110

this change depends on #122. thanks @amyliao for the mentorship on this one! resolves: #110
feat: make instance search errors non-fatal
Some checks failed
ci/woodpecker/pr/test Pipeline was canceled
e4fe3cd258 
Resolves: #110
pounce force-pushed nonfatal-search from e4fe3cd258
Some checks failed
ci/woodpecker/pr/test Pipeline was canceled
to f6726361f0
All checks were successful
ci/woodpecker/pr/test Pipeline was successful
2026年06月04日 19:27:06 +02:00 Compare
amyliao left a comment
Copy link

This is basically exactly the code I was imagining. Thanks!

This is basically exactly the code I was imagining. Thanks!
@ -921,0 +938,4 @@
then
k
else
HellNo <$> typeError (InstanceSearchDepthExhausted c a maxDepth)
Owner
Copy link

This is actually the same thing that was here before (fmap f (typeError _) = typeError _). You probably meant

 if d < maxDepth then k else
 HellNo <$> typeError_ (InstanceSearchDepthExhausted c a maxDepth)

Note the underscore to construct, instead of throwing, the error.

This is actually the same thing that was here before (`fmap f (typeError _) = typeError _`). You probably meant ```haskell if d < maxDepth then k else HellNo <$> typeError_ (InstanceSearchDepthExhausted c a maxDepth) ``` Note the underscore to construct, instead of throwing, the error.
pounce marked this conversation as resolved
address review comments
Some checks failed
ci/woodpecker/pr/test Pipeline was canceled
d5288146ab
pounce force-pushed nonfatal-search from d5288146ab
Some checks failed
ci/woodpecker/pr/test Pipeline was canceled
to d1a63e1033
All checks were successful
ci/woodpecker/pr/test Pipeline was successful
2026年06月04日 21:23:26 +02:00 Compare
amyliao changed target branch from aliao/defer-type-errors to main 2026年06月10日 21:56:14 +02:00
pounce force-pushed nonfatal-search from d1a63e1033
All checks were successful
ci/woodpecker/pr/test Pipeline was successful
to 595082c861
All checks were successful
ci/woodpecker/pr/test Pipeline was successful
ci/woodpecker/push/main Pipeline was successful
2026年06月13日 16:18:28 +02:00 Compare
Sign in to join this conversation.
No reviewers
Labels
Clear labels
1 - scope
language
 Backwards-compatible changes to the surface language, such as adding new features.
1 - scope
language change
 Breaking changes to a documented part of the surface language. These should be documented and specifically called out in the changelog.
1 - scope
performance
 Semantics-preserving performance work.
1 - scope
task
 Changes that are not apparent to the user, e.g. developer documentation and refactors, which do not need to be documented.
A: dead-code
Dead code elimination and --save-metas.
A: errors
Reporting of error and warning messages.
A: highlighting
Highlighting during interaction & literate compilation
A: imports
Handling of imports and interface file de/serialization.
A: infra
Iinfrastructure (e.g. CI, developer documentation, the build system, or the repository itself)
A: instance
Instance declarations, arguments, and resolution
A: lhs
LHS checking, coverage checking, and clause compilation
A: modules
Declaration and instantiation of parametrised modules.
A: parallel
Parallel typechecking.
A: positivity
Positivity checking
A: printing
Pretty-printing, display forms, and the wording of diagnostic messages
A: records
Record declarations, record expressions and copattern matching
A: scoping
Scope checking (ConcreteToAbstract)
A: termination
Termination checking
0 - type
bug
 Issues describing an incorrect behaviour in the project, typos in the documentation, etc.
0 - type
discussion
 An issue raised to gather opinions on a proposed change, or a suggested language change.
0 - type
question
 An issue raised to ask a question.
9 - status
duplicate
 This issue or pull request already exists.
9 - status
info needed
 More information is needed from the submitter to decide how to proceed with the issue report.
9 - status
invalid
 The issue report or pull request does not describe an actual bug, or does otherwise does not meet the contributing guidelines.
good first issue
Interested in contributing? Get started here.
upstream
Related to an upstream repository, already reported there
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
1lab/mikan!128
Reference in a new issue
1lab/mikan
No description provided.
Delete branch "pounce/mikan:nonfatal-search"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?