1lab/mikan
13
52
Fork
You've already forked mikan
9

Instance search failures should not be fatal #110

Closed
opened 2026年05月19日 17:21:07 +02:00 by amyliao · 1 comment

These two can be handled by adding a third case to the return type of findInstance and logging a warning instead of adding a constraint:

NoOutputTypeName -> typeError $ InvalidInstanceHeadType instTy ImproperInstHead
OutputTypeVisiblePi -> typeError $ InvalidInstanceHeadType instTy ImproperInstTele
case cands of
Left unblock -> do
reportSLn "tc.instance" 20 "Can't figure out target of instance goal. Postponing constraint."
addConstraint unblock $ FindInstance r m Nothing
Right cs -> findInstance m (Just cs)

It can't just be Left neverUnblock <$ warning ... because instance constraints can be retried even if their blocker hasn't changed.


This can be handled by turning the when into an if and returning HellNo ... instead of calling the continuation:

when (d > maxDepth) $ typeError $ InstanceSearchDepthExhausted c a maxDepth
k

This can be handled by logging a warning and returning Nothing, letting the meta go unsolved:

setCurrentRange (take' 1 $ map' snd sortedErrs) $
typeError $ InstanceNoCandidate t [ (candidateTerm c, err) | (c, err) <- sortedErrs ]
These two can be handled by adding a third case to the return type of `findInstance` and logging a warning instead of adding a constraint: https://codeberg.org/1lab/mikan/src/commit/fd926f03995138c6925e12f60c34ebdd6d5a65cc/src/full/Mikan/TypeChecking/InstanceArguments.hs#L79-L80 https://codeberg.org/1lab/mikan/src/commit/fd926f03995138c6925e12f60c34ebdd6d5a65cc/src/full/Mikan/TypeChecking/InstanceArguments.hs#L396-L400 It can't just be `Left neverUnblock <$ warning ...` because instance constraints can be retried even if their blocker hasn't changed. --- This can be handled by turning the `when` into an `if` and returning `HellNo ...` instead of calling the continuation: https://codeberg.org/1lab/mikan/src/commit/fd926f03995138c6925e12f60c34ebdd6d5a65cc/src/full/Mikan/TypeChecking/InstanceArguments.hs#L917-L918 --- This can be handled by logging a warning and returning `Nothing`, letting the meta go unsolved: https://codeberg.org/1lab/mikan/src/commit/fd926f03995138c6925e12f60c34ebdd6d5a65cc/src/full/Mikan/TypeChecking/InstanceArguments.hs#L564-L565
Contributor
Copy link

i'd like to give this a shot! reserving for now

i'd like to give this a shot! reserving for now
Sign in to join this conversation.
No Branch/Tag specified
main
aliao/occurs-opt
aliao/rec-con
fix-license
aliao/oopsie
aliao/strengthen-iapply
No results found.
Labels
Clear labels
1 - scope
language
Backwards-compatible changes to the surface language, such as adding new features.
1 - scope
language change
Breaking changes to a documented part of the surface language. These should be documented and specifically called out in the changelog.
1 - scope
performance
Semantics-preserving performance work.
1 - scope
task
Changes that are not apparent to the user, e.g. developer documentation and refactors, which do not need to be documented.
A: dead-code
Dead code elimination and --save-metas.
A: errors
Reporting of error and warning messages.
A: highlighting
Highlighting during interaction & literate compilation
A: imports
Handling of imports and interface file de/serialization.
A: infra
Iinfrastructure (e.g. CI, developer documentation, the build system, or the repository itself)
A: instance
Instance declarations, arguments, and resolution
A: lhs
LHS checking, coverage checking, and clause compilation
A: modules
Declaration and instantiation of parametrised modules.
A: parallel
Parallel typechecking.
A: positivity
Positivity checking
A: printing
Pretty-printing, display forms, and the wording of diagnostic messages
A: records
Record declarations, record expressions and copattern matching
A: scoping
Scope checking (ConcreteToAbstract)
A: termination
Termination checking
0 - type
bug
Issues describing an incorrect behaviour in the project, typos in the documentation, etc.
0 - type
discussion
An issue raised to gather opinions on a proposed change, or a suggested language change.
0 - type
question
An issue raised to ask a question.
9 - status
duplicate
This issue or pull request already exists.
9 - status
info needed
More information is needed from the submitter to decide how to proceed with the issue report.
9 - status
invalid
The issue report or pull request does not describe an actual bug, or does otherwise does not meet the contributing guidelines.
good first issue
Interested in contributing? Get started here.
upstream
Related to an upstream repository, already reported there
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
1lab/mikan#110
Reference in a new issue
1lab/mikan
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?