Skip to content

Update test environment to report failed assertions #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

WyriHaximus merged 1 commit into reactphp:1.x from clue-labs:assert

Oct 29, 2022

Merged

Update test environment to report failed assertions #300

WyriHaximus merged 1 commit into reactphp:1.x from clue-labs:assert

Oct 29, 2022

+49 −6

Conversation

Copy link

Member

@clue clue commented Oct 25, 2022

Builds on top of #299 and clue/framework-x#199
Refs shivammathur/setup-php#582 and shivammathur/setup-php#450

@clue clue added the maintenance label

@clue clue added this to the v1.13.0 milestone

@clue clue requested review from SimonFrings and WyriHaximus

October 25, 2022 09:37

@clue clue mentioned this pull request

Improve test suite, clean up leftover .sock files #301

Merged

@clue clue force-pushed the assert branch from 03d12d9 to 0456603 Compare

October 25, 2022 11:23

SimonFrings approved these changes

View reviewed changes

@SimonFrings SimonFrings self-requested a review

October 25, 2022 11:34

@clue clue force-pushed the assert branch 5 times, most recently from 1a5fd42 to 84e1373 Compare

October 26, 2022 06:25


 Update test environment to report failed assertions

4d44b5a

@clue clue force-pushed the assert branch from 84e1373 to 4d44b5a Compare

October 26, 2022 07:10

Copy link

Member Author

clue commented Oct 26, 2022

I've updated this to work around a super nasty bug in reactphp/async v4. Until this is fixed upstream (see reactphp/async#65), the work around already allows us to merge this as is. This work around can be removed again once fixed upstream, but it should not cause any issues in either case. Together with the changes upstream, you're looking at ~6h of work to achieve what should have been pretty much only a configuration change, enjoy! This is now ready for review. :shipit:

@clue clue mentioned this pull request

[4.x] Update test suite and report failed assertions reactphp/async#66

Merged

SimonFrings approved these changes

View reviewed changes

WyriHaximus approved these changes

View reviewed changes

@WyriHaximus WyriHaximus merged commit 936546b into reactphp:1.x

@clue clue deleted the assert branch

October 29, 2022 20:47

This was referenced Oct 30, 2022

[3.x] Update test suite and report failed assertions reactphp/async#67

Merged

[2.x] Update test suite and report failed assertions reactphp/async#68

Merged

[3.x] Update test suite and report failed assertions reactphp/promise#240

Merged

[2.x] Update test suite and report failed assertions reactphp/promise#241

Merged

[1.x] Update test suite and report failed assertions reactphp/promise#242

Merged

This was referenced Nov 13, 2022

Update test suite and report failed assertions reactphp/http#478

Merged

Update test suite and report failed assertions reactphp/stream#170

Merged

Update test suite and report failed assertions reactphp/dns#210

Merged

Update test suite and report failed assertions reactphp/cache#54

Merged

@clue clue mentioned this pull request

Update test suite and report failed assertions clue/reactphp-mq#37

Merged

@clue clue mentioned this pull request

Update test suite and report failed assertions reactphp/reactphp#501

Merged

@clue clue mentioned this pull request

Update test suite and report failed assertions clue/reactphp-sqlite#65

Merged

@SimonFrings SimonFrings mentioned this pull request

Test on PHP 8.1 and PHP 8.2, update test suite and report failed assertions clue/reactphp-zenity#62

Closed

@clue clue mentioned this pull request

Test on PHP 8.3 and update test environment #310

Merged

@SimonFrings SimonFrings mentioned this pull request

Fix typos in documentation clue/reactphp-csv#32

Merged

@SimonFrings SimonFrings mentioned this pull request

Run tests on PHP 8.3 and update test suite clue/reactphp-csv#33

Merged

This was referenced Nov 15, 2023

Run tests on PHP 8.3 and update test suite clue/reactphp-http-proxy#54

Merged

Run tests on PHP 8.3 and update test suite clue/reactphp-socks#113

Merged

This was referenced Nov 24, 2023

Run PHP 8.3 and update test suite clue/reactphp-ndjson#35

Merged

Run tests on PHP 8.3 and update test suite clue/reactphp-stdio#106

Merged

Run tests on PHP 8.3 and update test suite clue/reactphp-utf8#29

Merged

Run tests on PHP 8.3 and update test suite clue/reactphp-flux#29

Merged

Run tests on PHP 8.3 and update test suite clue/reactphp-redis#147

Merged

Run tests on PHP 8.3 and update test suite clue/reactphp-mdns#20

Merged

Run tests on PHP 8.3 and update test suite clue/reactphp-zenity#65

Merged

Run tests on PHP 8.3 and update test suite clue/reactphp-term#38

Merged

This was referenced Dec 19, 2023

Run tests on PHP 8.3 and update test suite clue/reactphp-docker#85

Merged

Run tests on PHP 8.3 and update test suite clue/stream-filter#51

Merged

@yadaiio yadaiio mentioned this pull request

Run tests on PHP 8.3 and update test suite clue/reactphp-mq#46

Merged

@yadaiio yadaiio mentioned this pull request

Run tests on PHP 8.3 and update test suite clue/reactphp-eventsource#44

Merged

This was referenced Jan 17, 2024

Run tests on PHP 8.3 and update test suite clue/reactphp-multicast#22

Merged

Run tests on PHP 8.3 and update test suite clue/arguments#17

Merged

Run tests on PHP 8.3 and update test suite clue/reactphp-shell#19

Merged

Run tests on PHP 8.3 and update test suite clue/reactphp-ssdp#16

Merged

Run tests on PHP 8.3 and update test suite clue/reactphp-tar#21

Merged

@SimonFrings SimonFrings mentioned this pull request

Update test suite and report failed assertions clue/reactphp-ami#78

Merged

This was referenced Apr 23, 2024

Run tests on PHP 8.3 and update test suite clue/reactphp-connection-manager-extra#38

Closed

Run tests on PHP 8.3, fix dynamic property for PHP 8.2 and update test suite clue/reactphp-ssh-proxy#40

Closed

@clue clue mentioned this pull request

[0.6.x] Run tests on PHP 8.3, update test suite and report failed assertions reactphp/child-process#113

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants

@clue @WyriHaximus @SimonFrings