-
-
Notifications
You must be signed in to change notification settings - Fork 18
Run tests on PHP 8.3 and update test suite #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
clue
reviewed
Dec 19, 2023
@yadaiio
yadaiio
force-pushed
the
test-suite
branch
from
December 19, 2023 09:25
5e04a51 to
cae4269
Compare
Contributor
Author
yadaiio
commented
Dec 19, 2023
Okay, should be fixed right now. 👍
clue
clue
approved these changes
Dec 19, 2023
Owner
@clue
clue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yadaiio Thanks for the update, changes LGTM! :shipit:
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This pull request builds on top of #80, #82, #83, #84 and #78.
References: reactphp/socket#300, clue/reactphp-zenity#63, clue/reactphp-csv#33, reactphp/promise-stream#39 and others.
After #83 was merged, I could go on with this pull request, thanks to @clue and @SimonFrings.