-
-
Notifications
You must be signed in to change notification settings - Fork 14
Run tests on PHP 8.3 and update test suite #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@SimonFrings
SimonFrings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yadaiio Thanks for filing this PR, can you also adjust the composer.json similar to how you did in clue/reactphp-multicast?
7367e8e to
da27303
Compare
yadaiio
commented
Jan 22, 2024
Thank you @SimonFrings for noticing this. Should be fixed now 😉
@SimonFrings
SimonFrings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changes, looks good 👍
@clue
clue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yadaiio Thanks for the update, changes LGTM! :shipit:
This pull request builds on top of #11.
References: reactphp/socket#300, clue/reactphp-zenity#63, clue/reactphp-csv#33 and others.