Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

enhance: Upgrade Claude Code hooks with advanced JSON reporting #6429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edmundmiller wants to merge 2 commits into master
base: master
Choose a base branch
Loading
from claude-hooks-enhanced

Conversation

Copy link
Member

@edmundmiller edmundmiller commented Sep 25, 2025 •
edited
Loading

Summary

This PR enhances the Claude Code development hooks with advanced JSON reporting capabilities, transforming them from simple pass/fail indicators into intelligent development assistants.

Enhanced Features

🔧 EditorConfig Hook (format-editorconfig.py)

  • File Change Detection: SHA256 hash comparison to identify specific formatting changes
  • Performance Metrics: Execution timing and eclint version reporting
  • Auto-Installation Progress: Real-time feedback during eclint installation
  • Structured Error Handling: JSON errors with actionable suggestions
  • Rich Success Messages: Detailed reporting of actual changes applied

🧪 Test Runner Hook (run-tests.py)

  • Gradle Output Parsing: Structured analysis of build results and timing
  • XML Test Result Parsing: Detailed test statistics with method names and execution times
  • Intelligent Failure Analysis: Pattern matching for NPEs, assertions, timeouts
  • Context-Aware Suggestions: File-specific recommendations based on failure patterns
  • Comprehensive Success Reporting: Test method details and build metrics

📊 Advanced JSON Output

  • Strategic Control Fields: Proper use of decision: "block", suppressOutput: true, systemMessage
  • Structured Metadata: Rich data for Claude's intelligent decision-making
  • Performance Insights: Timing metrics and progress indication
  • Enhanced Error Context: Detailed diagnostics with actionable fix suggestions

Benefits

  1. Better Claude Decision-Making: Structured data enables intelligent responses to test failures
  2. Actionable Feedback: Specific suggestions help Claude fix issues automatically
  3. Rich Context: Detailed results provide better understanding of changes and impacts
  4. Performance Insights: Timing and metrics help optimize development workflow
  5. User Experience: Clean, informative messages with progress indication

Copy link

netlify bot commented Sep 25, 2025 •
edited
Loading

✅ Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 87253b3
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/68e70bc20da1f40008bf1e5a

@edmundmiller edmundmiller marked this pull request as draft September 25, 2025 10:28
@edmundmiller edmundmiller force-pushed the claude-hooks-enhanced branch 2 times, most recently from 500782e to 41d9944 Compare September 25, 2025 10:35 
- Add EditorConfig enforcement hook using eclint
- Add smart test runner that maps source files to test classes 
- Support all modules (nextflow, nf-commons, nf-lang, etc.) and plugins
- Configure hooks to run on Edit/Write/MultiEdit operations
- Add comprehensive documentation in .claude/README.md
- Hooks provide immediate feedback on code formatting and test results
Signed-off-by: Edmund Miller <edmund.miller@seqera.io>
elif 'assertionerror' in failure_type or 'assertion' in failure_message:
suggestions.append(f"Review test assertions in {failed_test['name']}")
elif 'comparionfailure' in failure_type:
suggestions.append(f"Check expected vs actual values in {failed_test['name']}")
Copy link

@cursor cursor bot Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Typo in Function Name Causes JUnit Exception Handling Failure

The generate_failure_suggestions function contains a typo, comparionfailure, which should be comparisonfailure. This prevents the hook from correctly identifying JUnit ComparisonFailure exceptions, so specific suggestions for these test failures aren't generated.

Fix in Cursor Fix in Web

@edmundmiller edmundmiller force-pushed the claude-hooks-enhanced branch 3 times, most recently from 312bb99 to 7948f91 Compare October 8, 2025 21:07 
This commit adds a complete set of Claude Code hooks to improve the
development experience for Nextflow:
**Immediate Formatting (PostToolUse):**
- format-editorconfig.py: Applies editorconfig rules to all source files
- format-idea.py: Formats Groovy files with IntelliJ IDEA code style
**Build & Test Validation (Stop):**
- check-build.py: Runs 'make compile' to catch compilation errors
- run-tests.py: Runs corresponding test class for edited files
**Subagent Validation (SubagentStop):**
- check-build.py: Verifies subagent changes compile successfully
**Benefits:**
- Instant code formatting after each edit
- Build errors caught before tests run
- Tests only run once when agent finishes (not after each edit)
- Subagents validate compilation but skip slower test runs
- Non-blocking when optional tools (IDEA) not available
**Configuration:**
All hooks configured in .claude/settings.json with appropriate timeouts
and proper event triggers for optimal development workflow.
Signed-off-by: Edmund Miller <edmund.miller@seqera.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pditommaso pditommaso Awaiting requested review from pditommaso

1 more reviewer

@cursor cursor[bot] cursor[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /