Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

WIP: Capture all comments in parser #6332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ErikDanielsson wants to merge 6 commits into nextflow-io:master
base: master
Choose a base branch
Loading
from ErikDanielsson:fix-parser-comment-handling

Conversation

Copy link

@ErikDanielsson ErikDanielsson commented Aug 7, 2025
edited
Loading

This draft PR aims to add full support for finding comments in Nextflow source code and attaching them to the appropriate AST node. The additions to the parser are mirrored by the formatter classes used by the language server with the goal of addressing issues with the formatter removing comments.

Copy link

netlify bot commented Aug 7, 2025
edited
Loading

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 1102ed5
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/6894af89b7762c00083f7450
😎 Deploy Preview https://deploy-preview-6332--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ErikDanielsson ErikDanielsson changed the title (削除) WIP: Capture **all** comments in parser (削除ここまで) (追記) WIP: Capture all comments in parser (追記ここまで) Aug 7, 2025
Copy link
Member

Notes from today's meeting

We will investigate another approach in which the CST is converted directly into a formatting IR and used by the formatter.

We can also link CST nodes to AST nodes as needed to retrieve semantic information. But in the first iteration let's see how far we can get with just CST -> formatting IR -> formatter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /