-
Notifications
You must be signed in to change notification settings - Fork 738
Prevent using Azure Low Priority VMs when using Batch Managed mode #6267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Azure Low Priority VMs are deprecated in Batch Managed pool allocation mode but still supported in User Subscription mode. This adds validation to: - Block low priority VMs for Batch Managed accounts with clear error message - Allow low priority VMs for User Subscription accounts - Gracefully handle unknown allocation modes with warnings Adds subscriptionId to config to enable retrieval of this value. If not supplied Nextflow will raise a warning and continue. This does open us up to being able to do more with Azure Batch because we have access to the management API. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This is a sledgehammer to crack a nut - it may be easier just to drop support for low priority VMs altogether 😢
but it was a fun exercise with Claude Code reading an unfamiliar API for me.
Not sure this makes sense considering "low priority" feature is going to be retired on 30th Sept, 2025 by Microsoft
Apparently the lowPriority setting is also used to enable spot VMs which are the new replacement 🤦
Apparently the lowPriority setting is also used to enable spot VMs which are the new replacement
Umm, very confusing. We may still consider to call spot in Nextflow and align it with other cloud providers. In any case this PR needs a detailed docs to highlight what's new and how to use the new spot instances
https://learn.microsoft.com/en-us/azure/batch/batch-spot-vms
b7b4221 to
c1114bc
Compare
Uh oh!
There was an error while loading. Please reload this page.
Azure Low Priority VMs are deprecated in Batch Managed pool allocation mode but still supported in User Subscription mode. This adds validation to:
This required adding a
subscriptionIdto theazure.batchconfig to enable creation of the management client. If not supplied Nextflow will raise a warning and continue. This does open us up to being able to do more with Azure Batch because we have access to the management API.Fix Azure Low Priority VM deprecation for Batch Managed accounts (#6258)