-
Notifications
You must be signed in to change notification settings - Fork 739
Prefer to use CacheFunnel implementation when available for caching non-trivial objects #4077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
non-trivial objects. This change will allow us to define custom caching strategies for objects that are also Maps (custom Meta objects, for example). Signed-off-by: Rob Syme <rob.syme@gmail.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Jul 4, 2023
@pditommaso
pditommaso
force-pushed
the
master
branch
from
July 29, 2023 11:16
e377812 to
fcdeec0
Compare
@pditommaso
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
August 20, 2023 20:13
81f7cb7 to
8a43489
Compare
@pditommaso
pditommaso
force-pushed
the
master
branch
from
November 24, 2023 20:42
fd99141 to
19d2ccb
Compare
@pditommaso
pditommaso
force-pushed
the
master
branch
from
December 20, 2023 09:55
4e27468 to
dfd7d09
Compare
@pditommaso
pditommaso
force-pushed
the
master
branch
from
January 20, 2025 15:13
1f834a0 to
6454605
Compare
@pditommaso
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
February 10, 2025 21:46
5a93547 to
27345a6
Compare
@pditommaso
pditommaso
force-pushed
the
master
branch
from
April 9, 2025 16:18
f6a3696 to
49b58d2
Compare
@pditommaso
pditommaso
force-pushed
the
master
branch
3 times, most recently
from
June 4, 2025 18:54
b4b321e to
069653d
Compare
@pditommaso
pditommaso
force-pushed
the
master
branch
from
October 9, 2025 20:42
b7b4221 to
c1114bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow us to define custom caching strategies for objects that are also Maps (custom Meta objects, for example).
Currently, if a Map-like object implements CacheFunnel, it is never used because the CacheHelper's
value instanceof Mapwill return true earlier than the testvalue instanceof CacheFunnel.