openstack/manila-tempest-plugin - manila-tempest-plugin - OpenDev: Free Software Needs Free Tools

Fixed SharesActionsTest cases for API version >= 2.73
since a metadata field was added in that version.
Closes-bug: #1993283
Signed-off-by: Alexander Deiter <adeiter@infinidat.com>
Change-Id: Ib285d9c740558d1ff3e24acb1ccc3de7e1ad562f

The tests validate policy share actions for admin,member
and reader users in a project scope.
This patch adds tests for the following resources/features:
- share
- share snapshot
- share type
- share network
- scheduler stats
Below settings were used for ease of code development
and testing:
1. DHHS = False
2. Dummy driver as it supports all features
3. Manila-tempest-plugin as a base repo to test the changes
Depends-On: https://review.opendev.org/c/openstack/manila/+/858761
Change-Id: I53bb9851445038f81032485817389ec31e2b7341

Everything related to skip conditions in class level
should be under skip_checks class method.
Change-Id: I48441dc25b260f894fa8b6b5421f1739249c602a

As a fix to bug #1901210, manila's API now responds with
a 404 if a user doesn't have access to a non-public share to
prevent an existence detection attack. Since manila tempest tests
can be used for older branches without the fix, we must accommodate
both error codes - 403 and 404 in our tests for a while.
Change-Id: I27fdd7dfffeb15965b66dbb3f6b1568c11ff9ad4
Partial-Bug: #1901210
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

Change-Id: I44f0bf50c3d7042565dca54949965b2c4df1fb41
Closes-Bug: #1970661
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

There are few tests that generate random test names because
random parameters are given to the ddt.data decorator.
In the ddt version number 1.6.0 there is a possibility to
determine the name of the tests without relying on the
given values. I think this could be a good solution for
the randomly generated names.
Change-Id: Iaf39f4a83e383fb9db7f519136b9169352ff84af

We run IPv6 data-path tests with LVM and
Ceph-NFS drivers by setting up bgp to
advertise tenant network routes to the host.
Bug #1959666 prevents the use of OVN with
neutron-dynamic-routing. The underlying neutron
ML2 mechanism driver doesn't matter to
manila; so lets use OVS in the meanwhile with
these test jobs.
Closes-Bug: #1940324
Related-Bug: #1959666
Change-Id: I5b37f31e302ce75650f817a937d8f17ee58887b2
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

Change-Id: Ibbc849f59a71c3368bd997e93cf4fe09151add4d

Change-Id: I1f602209937866a44106129f3167fc659f657524

We'll need to pin manila-tempest-plugin in stable/victoria
when testing manila [1]; since the configuration is a special
snowflake for this branch alone, lets not carry it in this
branchless repository any more.
Depends-On: I23827477d3c25eb2b10bea6d62885d50a28ec0a0
[1] https://review.opendev.org/c/openstack/manila/+/850415
Change-Id: I6cfc413b3588e5d75a6ac6c9ebe6835541d4c4bc
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

I093be875910ef18deebe3e56b83c6992d1a307e5 introduced the
use of newer code from tempest that isn't available until
the 31.1.0 release.
Change-Id: Ibe2946fafd4d2b58d49b6c4040887346df1f9899
Related-Bug: #1968069
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

As tempest.scenario.manager was announced stable interface in Tempest
27.0.0[1] it can be now reused in plugins.
Deleted methods:
 * setup_clients
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: I3f63b3a0d4fd60b7824550f5c3deeb8cdb3d9ca9

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* get_networks (not used)
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: Ibb40445426fcf350ca6999558252f288a65a7dbf

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* _create_security_group_rule
	* _default_security_group
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: I18dd2a3d532273c8dfff730b4f13922717c0abf7

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* _create_security_group
	* _create_empty_security_group
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: I9b3245be474c3e23622de8e80e391247f2cf866f

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
_create_loginable_secgroup method isn't ready to be deleted yet, because its rulesets differs from tempest's. This method will be public now, so replaced methods will use this method over the tempest's one. Tempest doesn't allow to modify rulesets, but patch that will allow this is already proposed[2]. Some time after merging the mentioned tempest patch this plugin's implementation will be replaced.
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
[2] https://review.opendev.org/c/openstack/tempest/+/835018
Change-Id: I6b61d810c4695ac4709173a69f1b920b7228a1d0

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* _check_tenant_network_connectivity (not used)
	* _update_router_admin_state (not used)
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: Iea47467e3c8849981d4ed3bd9dc61834031d7be0

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* _check_remote_connectivity
	* check_remote_connectivity (not used)
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: Idd323660b21ea109d5f24efc0edab216723c8dca

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* _get_router
	* _create_router
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: I70e168160c1bfb8e5025bef8105d59a7dcc9da07

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* _create_subnet
	* create_networks (not used)
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: I516c4bdc5e93ac7521f546102c144bcb1c4d34af

As tempest.scenario.manager was announced stable interface in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* _create_security_group
	* _create_loginable_secgroup_rule
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: Idd6c9066cec143e358078babf1802dce60265114

Some recent changes introduced a branches variable into our yoga,
xena and wallaby jobs. Manila-tempest-plugin is branchless, so such
jobs should not have the branches variable assigned to them.
Change-Id: I8647d268ccd642def4a003f63ea26d804016c20f

As a continuation of the patch [1]. The required change
was merged in tempest. So we can make the cleanup in
manila_tempest_plugin.
[1] https://review.opendev.org/c/openstack/manila-tempest-plugin/+/836877
Change-Id: I093be875910ef18deebe3e56b83c6992d1a307e5

Adds a new check job to test FIPS compatibility with Manila
upstream CI. We currently only have means to enable FIPS on CentOS
systems. Ubuntu support will come in a later effort.
Starting from CentOS 8, there is no candidate for a quagga package
installation. Our IPv6 setup currently depends on quagga. If we
keep IPv6 enabled, the job won't even start. For now, the job will
only set up IPv4 and run the tests for this specific IP version.
Co-authored-by: Ashley Rodriguez <ashrod98@gmail.com>
Co-authored-by: Vida Haririan <vhariria@redhat.com>
Change-Id: Ica6445c582ceae4c5b9bbce48702c74710e6056f

This changes addresses few comments left in the change that
refactored some of our CI jobs [1], regarding a more suggestive
anchor name and a comment to give more context for code reviewers
in the future.
[1] https: //review.opendev.org/c/openstack/manila-tempest-plugin/+/847366
Change-Id: I4abf0d60e6662c6f409bfa6506ab51ea717dc8cf

In order to switch our manila service image to Ubuntu Jammy, we
needed to get in a couple of changes that Modified the flavor for
the manila service image. After all changes got merged, we switched
to the Ubuntu Jammy image [1].
However, now the manila service image master on Tarballs is using
a Ubuntu Jammy image, which requires more resources. It would not
be ideal to backport the changes that modify the flavor to the
stable branches because it is not an actual requirement for them,
and that also forced us to reduce concurrency of some jobs on the
master branch.
Using the Ubuntu Jammy image broke our stable branches CI, since
with less resources we are not able to successfuly spawn a nova
instance using the Ubuntu Jammy image.
In the stable branches, the jobs that spawn VMs will need to use
Ubuntu focal, so we have a new couple of jobs that will
selectively run against the stable branches and they will use a
pinned version of Ubuntu Focal from Tarballs.
These jobs were grouped into project templates to help us keep our
manifests readable.
Change-Id: I14afe2572c5bc8064417ba7ba3be26751022901d

1) Use the shares_v2_client to make metadata API requests.
This allows us to test v1 proxies as well where appropriate,
and actually test the supported version of the API instead
of the deprecated version
2) Verify key in GET /v2/shares/<share>/metadata/{key} API
the client's _parse_body helper strips out the top
level key allowing us to miss bugs associated with
any key changes from the server [1]. Allow for opt-in
verification of the key and add this verification
to the affected API.
[1] https://bugs.launchpad.net/manila/+bug/1968069
Depends-On: Ib5a62599b84ba55617071f8bcd8e2a1a11b2537b
Change-Id: I7b1af957f08328c642a74ff123deb78e193bbe3a
Related-Bug: #1968069
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

Due to some test constraints, we decided to migrate the
manila-service-image to Jammy Jellyfish [1]. In order to have the
jobs passing, we needed to grant more resources to the service VMs,
but it would not be ideal to backport those changes to the stable
branches.
We decided we would pin the manila-service-image to a ubuntu Focal
image in the stable branch, and with that we would not need to
backport the other changes we merged in order to switch the image.
[1] https://review.opendev.org/c/openstack/manila-image-elements/+/841264
Change-Id: I74f81e92297ad58ebd4266511bb62b5fe24f7cb5

As tempest.scenario.manager was announced stable interface
in Tempest 27.0.0[1] it can be now reused in plugins.
Replaced methods:
	* _associate_floating_ip
	* check_floating_ip_status
Etherpad concerning this effort:
https://etherpad.opendev.org/p/tempest-scenario-manager-cleanup
The commit also bumps the minimal version of tempest in the
requirements to tempest>=27.0.0.
[1] https://docs.openstack.org/releasenotes/tempest/v27.0.0.html#release-notes-27-0-0
Change-Id: Ie17c1d9349e98ce016801bf47c1cb9dba18b51f6