openstack/manila-tempest-plugin - manila-tempest-plugin - OpenDev: Free Software Needs Free Tools

API access-allow returns following redundant data:
- deleted
- deleted_at
- instance_mappings
So, remove them for create share api method and cover it with
unit and tempest tests.
Change-Id: I103380c3f0008d4879b39f339187e57eeec40456
Closes-Bug: #1499733 

This patch changes the creation of security services in Manila
tempest to use randomized IP addresses instead of name-like strings
for both the 'dns_ip' and 'server' fields. The use of a name-like
string for the dns_ip field does not make sense from a positive test
perspective. The server field is more ambiguous in whether it should
take an IP or a hostname, but since nearly anything that can take a
hostname can also accept an IP, but not necessarily the reverse
(e.g. the NetApp drivers are expecting an IP), then it makes more
sense to use an IP here as well to cater to a broader audience.
The rand_ip() method is not in an ideal location. My preference
would be to push for this method to make it into the
tempest_lib.common.utils.data_utils package along with all the other
rand_whatever() methods. However, until that can be submitted,
accepted, and released, it will need to live inside the manila tests
temporarily.
Closes-bug: 1500899
Change-Id: I7dbeb9407e056266cc7a61722365f70ab668a525

Tempest test module "test_shares_actions.py" uses custom share_type,
but do not allow to redefine extra spec "snapshot_support".
And fails for drivers that do not have snapshot support and report
such capability as "False".
Changes:
- Add new config option called "capability_snapshot_support" that
will be used for each share type created in Tempest by default.
- Make it default to existing config option "run_snapshot_tests"
as they will be equal in most cases. But separate their logic, as
we may want just to disable snapshot tests running tempest locally
and testing some other feature having snapshot support in back end.
- Rename existing config option "storage_protocol" to
"capability_storage_protocol" for consistency with new option. And
keep old name as "deprecated".
Change-Id: I9ba0a9b10ffc3f0fda6094a3f5cad26a2e8a447f
Closes-Bug: #1498858 

A previous patch added experimental=True to hide task_state field
for any API call that would return share fields, such as "create"
and "get" calls if different than microversion "2.5" with
experimental=True. Turns out the field task_state should be
returned always if microversion is "2.5" or above because it
relates to a change in DB, not only to the usage of Share Migration
feature. This patch fixes it by removing experimental=True
dependency to show task_state field.
Closes-bug: #1497352
Change-Id: Ic07d63ebcfe25c1cfa3fac1e75e2e186fbcec25b

The Tempest tests for the scheduler's pool-list filters can match pools
other than the ones they should, because the regex strings are not
wrapped with ^ and $. We hit this in the NetApp CI system.
Closes-Bug: #1496375
Change-Id: I423ea164ff62df87e31e5b0ed5cf19870e897cde

This bug, inherited from Cinder, allows a tenant to view share
extra specs using the extra-specs-list CLI command. The Cinder
fix was to check the admin context in the DB layer and filter out
all extra specs for non-admins. This approach doesn't work for
Manila, because some extra specs are required and are effectively
part of the Manila API (DHSS, snapshot_support). So in Manila we
define a set of tenant-visible extra specs and restrict the extra
spec values to that set in the share type view builder. Also, we
add policies for the share type list APIs so that admins can
control access to those if desired.
The separate API to list extra specs already has adequate checking
for non-admin users; the CLI was listing the extra specs returned
by the share type API, which is now filtered as described.
Co-Authored-By: Andrew Kerr <andrew.kerr@netapp.com>
Change-Id: I9b0a8ddc064c246286f26760b703db6e3e1bcd46
Closes-Bug: #1475285 

Recently was introduced feature where snapshots become optional.
Share started have new attr "snapshot_support". But it is absent in
share payload and, hence, can not be used outside of Manila.
Also, fix lost import of translation function for related snapshot API.
Change-Id: Iddb0cf1e046b9d480a22e79b33c8674a2405362e
Closes-Bug: #1491345
Closes-Bug: #1491346 

After Share Migration was included, the task_state field was
added to be displayed on GET requests, but API versions prior to
2.5 should not see this field. This patch fixes that by using
microversions.
Closes-bug: #1494746
Change-Id: Ie755ae53fe8efdf1702a0ecbabf022a5fe4beb93

APIImpact
Change-Id: I082bdac82c981adf733c709472ce1b9e26d5650b
Closes-Bug: #1483886 

Change Manila tempest scenario tests to be able to work
with drivers in 'driver_handles_share_servers = False' mode.
Closes-bug: #1483686
Change-Id: Iefa6718e8b537468e5f4f9ce50cccdf0cafe737d

This patch addresses issues commented on
change I64b0a3ee77b27278cc294f72702408a27888e0e9
after it was merged, according to bug below.
Closes-bug: #1494000
Change-Id: I9079ea16e0edc359b380705bebba2a7e98446d5c

In ShareManager::manage_existing(), there is a check for the DHSS mode of
the driver but there is no check for the DHSS mode in the specified share
type. This omission requires redundant checks in the drivers. This patch
adds the missing check to the share manager, removes the redundant checks
from the drivers, and updates all relevant unit tests. Also, fix a
couple minor tempest resource cleanup issues discovered while
debugging this issue.
Change-Id: Ib579fd0558e59c28777342bb9d36def12f6bf4da
Closes-Bug: #1493869 

To prevent a microversioned client from managing a non-microversioned
Manila server, Manila must update its REST endpoints by adding /v2 for
all microversioned APIs.
This commit does the following:
* Add /v2 to the URL map, connected to all the same /v1 API methods
* Renumber the microversion sequence starting from 2.0
* Update the versions API to reflect v2
* Publish the new endpoint to Keystone in the DevStack plug-in
* Update relevant documentation
* Update Tempest tests for microversions
APIImpact
Co-Authored-By: Andrew Kerr <andrew.kerr@netapp.com>
Closes-Bug: 1488624
Change-Id: I56a516b5f81914557dd2465746629431cfd6deac

Tempest test 'test_list_shares_with_detail_filter_by_extra_specs' fails
with following error from time to time:
ValueError: Share 'cdd499f7-6b02-4f47-8b39-7093b4d07e11' listed with
extra_specs filter has nonexistent share type 'share-type-1283899337'.
It happens because list of share types is taken for each step of a loop
Get list of share types only once and before taking list of shares, in
that case we will have share objects with still existing share types.
Change-Id: I0c29d16385255599b902757544e31ebbec79ca84
Closes-Bug: #1493125 

This patch replaces xrange() in python 2 to range() to
make it compatible with python 3.
Change-Id: Ic257ff77475a5ea8d2b4f00a00d710e296fc3602

Use novaclient for creation of keypair instead of openstack client in
devstack plugin, because the latter is not compatible with
nova microversion 2.1
Also, specify explicitly Nova API version in manila wrapper over
novaclient that is used by Generic and Windows drivers.
Also, revert back amount of tempest threads for Ci jobs to avoid job
timeout failures.
Also, fix raise of SnapshotBuildErrorException in Tempest plugin.
Tempest tries to raise exception SnapshotBuildErrorException from wrong
place. It should use "share_exceptions" instead of "exceptions".
Change-Id: Ie9ea9f6d25a13f8cd8f0ccbc73f6fa75cca35e0b
Closes-Bug: #1493008
Closes-Bug: #1493072 

This commit adds tempest functional tests for Manila consistency
groups and cgsnapshot objects and actions. By default these tests are
enabled; 3rd party CI systems should disabled these tests through the
RUN_MANILA_CG_TESTS environment variable if their driver does not
support consistency groups.
Partially implements bp manila-consistency-groups
Change-Id: I3297e02ad53c328f0bfe5245fefdb6af80552b4a

Recent update to Tempest plugin was moving existing test modules to different
place. And module 'test_microversions' was missed and not moved.
Change-Id: Id19fdb64f12b59c36118c097e2ca7136646c76b3
Depends-On: Ie9ea9f6d25a13f8cd8f0ccbc73f6fa75cca35e0b
Closes-Bug: #1493009 

This patch adds functional tests for Share Migration,
running on generic driver DHSS = true mode.
Implements: blueprint share-migration
Change-Id: I64b0a3ee77b27278cc294f72702408a27888e0e9

This patch adds the /consistency-groups and /cgsnapshots
endpoints as well as AdminActions for both.
Partially implements bp manila-consistency-groups
APIImpact
Change-Id: I5fd0d3341766fdba4d92f4a43c3d1186e7a4b38e

Make use of the Tempest plugin interface instead of copying Manila
files into Tempest. This will remove the burden to port Manila
tests onto Tempest master recurrently.
This ports all existing Manila Tempest test to the new structure.
It uses manila_tempest_tests as new top folder for all Tempest
tests. It follow the model of Heat (see [1]).
[1]: https://github.com/openstack/heat/tree/master/heat_integrationtests
Change-Id: Ie5ed64a6777ed1acf8dd56522c26705ae897596d
Partly-implements: bp tempest-plugin-interface
Depends-On: I26dd32b1de8cceeaa6dc674092efec683df71889