Add support for PHP 8, update dependencies' versions #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

samdark merged 61 commits into yiisoft:master from arogachev:3.0

Nov 30, 2021

Merged

Add support for PHP 8, update dependencies' versions #220

samdark merged 61 commits into yiisoft:master from arogachev:3.0

Nov 30, 2021

Conversation

@arogachev

Copy link

Contributor

@arogachev arogachev commented Nov 3, 2021 •

edited

Loading

Q	A
Is bugfix?	✔️/❌
New feature?	✔️/❌
Breaks BC?	✔️/❌
Fixed issues	#203, #146, #213, #133, #155, #162, #179, #199, #148

Related:

TODO list (required):

Fix filling of type and types in other places, extract common logic.
Restore filling of endLine in BaseDoc.
Get rid of hard coded isReturnByReference in FunctionDoc.
Handle commented out code - $reflector->getNode()->default.
Fix tests.
Test larger codebases (Yii 2 framework).
Actualize docstrings.
Update changelog.
Figure out what's preventing PHPUnit to install when running composer install locally.

TODO list (optional):

Actualize tests in phpDocumentor/Reflection fork.
Rename reflector to element.

Improvements / acceptable additional changes:

Type and description are not shown (https://www.yiiframework.com/doc/api/2.0/yii-base-controller#bindInjectedParams()-detail).
callback -> callable.
mixed[] -> array.
Fixed broken links (including in @see tags).
Removed leading backslash in event name (\yii\db\Event - > yii\db\Event). This is also more consistent with other class names now.
\\ -> \ (inside of strings,'app\\controllers -> 'app\controllers'). Very few cases, not a big issue in my opinion.
More correct rendering of HEX numbers (1 -> 0x1). Previously they were displayed as integers (the beginning was cut off).
HEX colors are now in lower case (0xFFFFFF -> 0xffffff).
Short class name in agruments in method signature. Before: protected string formatMessage ( $message, $format = [\yii\helpers\Console::FG_RED, \yii\helpers\Console::BOLD] ) After: protected string formatMessage ( $message, $format = [Console::FG_RED, Console::BOLD] ).
Incomplete description: "Prepare select-subquery and field names for INSERT INTO ... SELECT SQL statement." (".. SELECT SQL statement." part was cut off).
Unified \Exception (\Throwable was redundant).
Removed redundant raw Markdown link wrap (https://www.yiiframework.com/doc/api/2.0/yii-web-urlnormalizerredirectexception#$scheme-detail).
Removed @see tags that refer to private properies and methods.
Fix typos in @see tags causing broken links.
Methods declared via @method tag are not rendered as inherited now (1 case only).
Fix method name and order accordingly (declared via @method tag) https://www.yiiframework.com/doc/api/2.0/yii-db-activerelationtrait#()-detail.
Backslashes in class names are not highlighted separately (begavior of highlight_string function was changed in PHP 8).

Thanks to @bizley for initial attempt and changes. 👏

Bizley and others added 3 commits

August 30, 2021 15:20


 Draft for 3.0

7aa586d

@arogachev


 Merge remote-tracking branch 'origin/3.0' into 3.0

0f5df6c

@arogachev


 Simplify dependencies in composer.json

b8e27f6

@samdark samdark requested review from a team and bizley

November 3, 2021 07:12

@arogachev


 Minimal working version, various fixes

ac33ed2

@arogachev arogachev changed the title ~~(削除) Draft for 3.0 (削除ここまで)~~ (追記) Add support for PHP 8 (追記ここまで)

Nov 4, 2021

arogachev added 2 commits

November 4, 2021 12:05

@arogachev


 Remove older PHP versions for tests, add PHP 8

072e760

@arogachev


 Allow PHP 8 as a dependency in composer.json

1ac13d8

@samdark samdark added the type:enhancement label

Nov 4, 2021

arogachev added 6 commits

November 4, 2021 13:08

@arogachev


 Leave hard coded value (isReturnByReference in FunctionDoc)

79f933e

@arogachev


 Remove unnecessary elseif block

b1095fc

@arogachev


 Move construct method to the top, remove commented out code

c70b044

@arogachev


 Make use of StringHelper::mb_ucfirst()

22ab8c5

@arogachev


 Actualize stubs for setting type and types based on getType()

2f798bf

@arogachev


 Use fork, restore endLine and isReturnByReference logic

186944f

@arogachev arogachev changed the title ~~(削除) Add support for PHP 8 (削除ここまで)~~ (追記) Add support for PHP 8, update dependencies' versions (追記ここまで)

Nov 5, 2021

arogachev added 3 commits

November 5, 2021 11:44

@arogachev


 Handle getNode()->default, do not remove deprecated methods' bodies

aaf5dbd

@arogachev


 Removed author for consistency

d12e8ce

@arogachev


 Cleanup

@arogachev arogachev self-assigned this

Nov 5, 2021

@arogachev arogachev changed the title ~~(削除) Add support for PHP 8, update dependencies' versions (削除ここまで)~~ (追記) Add support for PHP 8, update dependencies' versions (fix #203, #146, #213) (追記ここまで)

Nov 5, 2021

@arogachev arogachev changed the title ~~(削除) Add support for PHP 8, update dependencies' versions (fix #203, #146, #213) (削除ここまで)~~ (追記) Add support for PHP 8, update dependencies' versions (追記ここまで)

Nov 5, 2021

arogachev added 7 commits

November 5, 2021 12:38

@arogachev


 Handle type / types in TypeDoc, get rid of addProjectFile

7f1178a

@arogachev


 Fix undefined variable $type

b3b44fc

@arogachev


 Cleanup tests

e4f989c

@arogachev


 Fix first 5 errors after testing on Yii 2 docs

ab6b134

@arogachev


 Make setUp compatible with parent (PHPUnit)

01f5450

@arogachev


 Fix "Undefined array key 0" error

63f5426

@arogachev


 Fix "Call to undefined method Generic::getContent()" in Context

1207b7a

arogachev added 5 commits

November 23, 2021 19:48

@arogachev


 Fix issue #143 (do not include internal methods and properties) [skip...

7e98c64

... ci]

@arogachev


 Add issue #180 in CHANGELOG.md[skip ci]

255733f

@arogachev


 Add issue #148 to CHANGELOG.md [skip ci]

f9bef8f

@arogachev


 Fixed issue #197 [skip ci]

5b2f0b7

@arogachev


 Add prefix and suffix when fixing Markdown links

7ceaa5a

@arogachev arogachev mentioned this pull request

Nov 25, 2021

Added support for todos in properties and methods #223

Merged

arogachev added 3 commits

November 25, 2021 12:01

@arogachev


 Merge branch 'master' into 3.0

969362b

# Conflicts:
#	CHANGELOG.md

@arogachev


 Do not add guide prefix to non-Markdown links

bb94d19

@arogachev


 Extract changes for issue #180 to a separate branch

5b068ef

This was referenced Nov 25, 2021

Do not include methods and properties marked as internal #224

Closed

Do not include methods and properties marked as internal #225

Merged

@arogachev


 Extract changes for issue #197 to a separate branch

d97b25c

This was referenced Nov 25, 2021

Adapted fixing of Markdown links for multiple links #226

Merged

Error: Syntax error, unexpected T_PAAMAYIM_NEKUDOTAYIM on line 220 #205

Closed

@arogachev


 Remove whitespace at the end of line [skip ci]

0ec0800

@arogachev arogachev mentioned this pull request

Nov 25, 2021

Added support for PHPDoc inline links #227

Merged

samdark

samdark reviewed

Nov 25, 2021

View reviewed changes

composer.json

"require-dev": {

"cweagans/composer-patches": "^1.7",

"phpunit/phpunit": "4.8.34"

"phpunit/phpunit": "*"

Copy link

Member

@samdark samdark Nov 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to specify versions more explicitly.

Copy link

Contributor Author

@arogachev arogachev Nov 26, 2021 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how it was in @bizley's draft (initial commit). Maybe there is a reason for that? Different PHP versions I guess? 🤔 Anyway I agree with you, in terms of dependencies this is not safe. I'll take a look.

Copy link

Member

@bizley bizley Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I did it like that because we usually don't have constraint on the PHP version. I can see now that since we have it limited we should also limit phpunit but still allowing all range of it for the given php versions.

@arogachev arogachev mentioned this pull request

Nov 29, 2021

Fixed extracting of first sentence from the text containing backticks #228

Merged

@arogachev

Copy link

Contributor Author

arogachev commented Nov 29, 2021

@bizley You are probably busy now, but do you have time for review? 🤔

@bizley

Copy link

Member

bizley commented Nov 29, 2021

Oh, sweet, is it ready? I'll find some time for sure.

@arogachev

Copy link

Contributor Author

arogachev commented Nov 29, 2021

Oh, sweet, is it ready? I'll find some time for sure.

That's great! 👍 Yes, it's ready for review.

arogachev added 2 commits

November 29, 2021 16:25

@arogachev


 Group overridden methods together [skip ci]

632f520

@arogachev


 Add " @link " tag [skip ci]

318f465

@arogachev arogachev mentioned this pull request

Nov 29, 2021

Added pretty print for arrays #231

Merged

@arogachev


 Merge branch 'master' into 3.0

a9bdddf

# Conflicts:
#	CHANGELOG.md

samdark

samdark approved these changes

Nov 30, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

@samdark


 Update CHANGELOG.md

be2d2d0

@samdark samdark merged commit 3adbcd1 into yiisoft:master

Nov 30, 2021

@arogachev arogachev deleted the 3.0 branch

December 28, 2021 05:57

@arogachev arogachev mentioned this pull request

Dec 28, 2021

Get rid of Reflection's fork #263

Closed

7 tasks

Labels

type:enhancement

4 participants

@arogachev @samdark @bizley @rob006

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add support for PHP 8, update dependencies' versions #220

Add support for PHP 8, update dependencies' versions #220

Uh oh!

Conversation

@arogachev arogachev commented Nov 3, 2021 •

edited

Loading

Uh oh!

Uh oh!

@samdark samdark Nov 25, 2021

Choose a reason for hiding this comment

Uh oh!

@arogachev arogachev Nov 26, 2021 •

edited

Loading

Uh oh!

Choose a reason for hiding this comment

Uh oh!

@bizley bizley Nov 29, 2021

Choose a reason for hiding this comment

Uh oh!

arogachev commented Nov 29, 2021

Uh oh!

bizley commented Nov 29, 2021

Uh oh!

arogachev commented Nov 29, 2021

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Add support for PHP 8, update dependencies' versions #220

Add support for PHP 8, update dependencies' versions #220

Uh oh!

Conversation

@arogachev arogachev commented Nov 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

@samdark samdark Nov 25, 2021

Choose a reason for hiding this comment

Uh oh!

@arogachev arogachev Nov 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

@bizley bizley Nov 29, 2021

Choose a reason for hiding this comment

Uh oh!

arogachev commented Nov 29, 2021

Uh oh!

bizley commented Nov 29, 2021

Uh oh!

arogachev commented Nov 29, 2021

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

@arogachev arogachev commented Nov 3, 2021 •

edited

Loading

@arogachev arogachev Nov 26, 2021 •

edited

Loading