Fixed extracting of first sentence from the text containing backticks #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

samdark merged 64 commits into yiisoft:master from arogachev:128-first-sentence-backticks

Dec 1, 2021

Merged

Fixed extracting of first sentence from the text containing backticks #228

samdark merged 64 commits into yiisoft:master from arogachev:128-first-sentence-backticks

Dec 1, 2021

Conversation

@arogachev

Copy link

Contributor

@arogachev arogachev commented Nov 29, 2021 •

edited

Loading

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌
Fixed issues	#128

Bizley and others added 30 commits

August 30, 2021 15:20


 Draft for 3.0

7aa586d

@arogachev


 Merge remote-tracking branch 'origin/3.0' into 3.0

0f5df6c

@arogachev


 Simplify dependencies in composer.json

b8e27f6

@arogachev


 Minimal working version, various fixes

ac33ed2

@arogachev


 Remove older PHP versions for tests, add PHP 8

072e760

@arogachev


 Allow PHP 8 as a dependency in composer.json

1ac13d8

@arogachev


 Leave hard coded value (isReturnByReference in FunctionDoc)

79f933e

@arogachev


 Remove unnecessary elseif block

b1095fc

@arogachev


 Move construct method to the top, remove commented out code

c70b044

@arogachev


 Make use of StringHelper::mb_ucfirst()

22ab8c5

@arogachev


 Actualize stubs for setting type and types based on getType()

2f798bf

@arogachev


 Use fork, restore endLine and isReturnByReference logic

186944f

@arogachev


 Handle getNode()->default, do not remove deprecated methods' bodies

aaf5dbd

@arogachev


 Removed author for consistency

d12e8ce

@arogachev


 Cleanup

@arogachev


 Handle type / types in TypeDoc, get rid of addProjectFile

7f1178a

@arogachev


 Fix undefined variable $type

b3b44fc

@arogachev


 Cleanup tests

e4f989c

@arogachev


 Fix first 5 errors after testing on Yii 2 docs

ab6b134

@arogachev


 Make setUp compatible with parent (PHPUnit)

01f5450

@arogachev


 Fix "Undefined array key 0" error

63f5426

@arogachev


 Fix "Call to undefined method Generic::getContent()" in Context

1207b7a

@arogachev


 Fix "Class Collection not found" error

fcafd6a

@arogachev


 Fix regression with parentheses with MethodDoc

f246153

@arogachev


 Fix property-read / property-write parsing issues

73f12e8

@arogachev


 Fix event description (was merged with class name and not capitalized)

3b700bd

@arogachev


 Fix issue when "seeAlso" partial template was not rendered

7b3e0d3

@arogachev


 Revert str_contains -> strpos

b381335

@arogachev


 Handle null in aggregated type during split types

598c559

@arogachev


 Fix broken links

1b432ff

arogachev added 11 commits

November 23, 2021 19:48

@arogachev


 Fix issue #143 (do not include internal methods and properties) [skip...

7e98c64

... ci]

@arogachev


 Add issue #180 in CHANGELOG.md[skip ci]

255733f

@arogachev


 Add issue #148 to CHANGELOG.md [skip ci]

f9bef8f

@arogachev


 Fixed issue #197 [skip ci]

5b2f0b7

@arogachev


 Add prefix and suffix when fixing Markdown links

7ceaa5a

@arogachev


 Merge branch 'master' into 3.0

969362b

# Conflicts:
#	CHANGELOG.md

@arogachev


 Do not add guide prefix to non-Markdown links

bb94d19

@arogachev


 Extract changes for issue #180 to a separate branch

5b068ef

@arogachev


 Extract changes for issue #197 to a separate branch

d97b25c

@arogachev


 Remove whitespace at the end of line [skip ci]

0ec0800

@arogachev


 Fixed extracting of first sentence from the text containing backticks

e1baa3d

@arogachev arogachev added the type:enhancement label

Nov 29, 2021

@arogachev arogachev requested a review from a team

November 29, 2021 05:17

@arogachev arogachev self-assigned this

Nov 29, 2021

@arogachev arogachev added type:bug and removed type:enhancement labels

Nov 29, 2021

@samdark


 Merge branch 'master' into 128-first-sentence-backticks

5bfb0f3

bizley

bizley reviewed

Nov 30, 2021

View reviewed changes

models/BaseDoc.php

/**

* @param Type|null $aggregatedType

* @return string[]|array

Copy link

Member

@bizley bizley Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

* @return string[]|array

* @return string[]

Copy link

Contributor Author

@arogachev arogachev Dec 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Because PR is already merged, I'll fix it in a separate commit.

bizley

bizley reviewed

Nov 30, 2021

View reviewed changes

models/BaseDoc.php

$types[] = (string) $type;

}

return $types ?: [(string) $aggregatedType];

Copy link

Member

@bizley bizley Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Type stringable?

Copy link

Contributor Author

@arogachev arogachev Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is.

arogachev added 4 commits

December 1, 2021 12:21

@arogachev


 Merge branch 'master' into 128-first-sentence-backticks

0d734a0

# Conflicts:
#	CHANGELOG.md

@arogachev


 Merge remote-tracking branch 'origin/128-first-sentence-backticks' in...

9fe7274

...to 128-first-sentence-backticks
# Conflicts:
#	CHANGELOG.md

@arogachev


 Sync CHANGELOG.md with master

e04ed05

@arogachev


 Sync PrettyPrinter.php with master

0b23716

@samdark samdark added the status:code review label

Dec 1, 2021

samdark

samdark approved these changes

Dec 1, 2021

View reviewed changes

@samdark


 Merge branch 'master' into 128-first-sentence-backticks

3bde22d

@samdark samdark merged commit ef36239 into yiisoft:master

Dec 1, 2021

@arogachev arogachev deleted the 128-first-sentence-backticks branch

December 2, 2021 08:31

This was referenced Dec 2, 2021

(Chore) Fixed changelog order, fixed return type #234

Closed

BaseDoc::extractFirstSentence() must consider previous text #235

Merged

Labels

status:code review type:bug

3 participants

@arogachev @samdark @bizley

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fixed extracting of first sentence from the text containing backticks #228

Fixed extracting of first sentence from the text containing backticks #228

Uh oh!

Conversation

@arogachev arogachev commented Nov 29, 2021 •

edited

Loading

Uh oh!

Uh oh!

@bizley bizley Nov 30, 2021

Choose a reason for hiding this comment

Uh oh!

@arogachev arogachev Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

@bizley bizley Nov 30, 2021

Choose a reason for hiding this comment

Uh oh!

@arogachev arogachev Dec 1, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Fixed extracting of first sentence from the text containing backticks #228

Fixed extracting of first sentence from the text containing backticks #228

Uh oh!

Conversation

@arogachev arogachev commented Nov 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

@bizley bizley Nov 30, 2021

Choose a reason for hiding this comment

Uh oh!

@arogachev arogachev Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

@bizley bizley Nov 30, 2021

Choose a reason for hiding this comment

Uh oh!

@arogachev arogachev Dec 1, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

@arogachev arogachev commented Nov 29, 2021 •

edited

Loading