Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix ajax parameters when ? was used on based url. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yajra merged 1 commit into yajra:master from OzanKurt:patch-1
Feb 16, 2017
Merged

Fix ajax parameters when ? was used on based url. #5

yajra merged 1 commit into yajra:master from OzanKurt:patch-1
Feb 16, 2017

Conversation

@OzanKurt
Copy link
Contributor

@OzanKurt OzanKurt commented Feb 10, 2017

Hi, I added support for rendering 2 tables in a single page.

The idea was pretty simple.

I had 2 tables in /users, ActiveUsersDataTable and InactiveUsersDataTable.

  • I added and id field to use in html part of the datatable so that the ids won't conflict.
  • I added ?tableId=TableID to each request so that we can define which table we're querying with the ajax request to the backend.
  • I edited the server-side.buttons.js to allow urls with a query parameter.

Copy link
Owner

yajra commented Feb 10, 2017

Looks good. Will do some testing along with your other PR when it's adjusted to be optional. Thanks!

OzanKurt reacted with thumbs up emoji

Copy link
Contributor Author

Let me know if something is needed.

@yajra yajra changed the title (削除) Adding Multiple Table Rendering Feature (削除ここまで) (追記) Fix ajax parameters when ? was used on based url. (追記ここまで) Feb 16, 2017
@yajra yajra merged commit 9710cf2 into yajra:master Feb 16, 2017
Copy link
Owner

yajra commented Feb 16, 2017

Released on v1.0.1, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /