-
-
Couldn't load subscription status.
- Fork 69
Adding Multiple Table Rendering Feature #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note: This is in connection with yajra/laravel-datatables-buttons#5
I added ?tableId=TableID to each request so that we can define which table we're querying with the ajax request to the backend.
I think we should make this parameter optional. The PR will always add this parameter which is not needed by some of the users. This is also the reason why the test fails.
Yeah that can be optional for sure. Would you like to have a look yourself, or should I try?
Can you please try first. Having a lot of incoming task lately and I may not be able to look at this asap. Thanks!
@yajra Done some changes.
@OzanKurt thanks for the changes. Will try to check and release this within week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late response, I think this part may cause some breaking change? What if we already have a query string on our default URL?
'ajax' => '/data?user_id=1', ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, I had that issue and also updated accordingly. I am currently so overwhelmed by projects, sadly don't have time to re-think some code and push them.
Sorry for overlooking this. Please submit a new PR if still interested to have this. Thanks!
Hi, I added support for rendering 2 tables in a single page.
The idea was pretty simple.
I had 2 tables in
/users,ActiveUsersDataTableandInactiveUsersDataTable.idfield to use in html part of the datatable so that the ids won't conflict.?tableId=TableIDto each request so that we can define which table we're querying with the ajax request to the backend.server-side.buttons.jsto allow urls with a query parameter.