-
-
Notifications
You must be signed in to change notification settings - Fork 695
Breaking: support ESLint 5 and drop the supports of old stuffs #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The top-level commas are invalid syntax.
michalsnik
michalsnik
approved these changes
Jul 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! We should however also mention that this README is about the upcoming version 5, and that for the last stable version people should go here: https://github.com/vuejs/eslint-plugin-vue/tree/4.x
I updated README.md with copying from dfcd26e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #398, fixes #423, fixes #521, closes #504.
This PR does:
vue-eslint-parserto 3.x to support ESLint 5 and fix several bugs. See v3.0.0 to check changes. Notable changes are:slot-scopeand<template scope>attributes was changed. Those attributes are now parsed toVSlotScopeExpressionnode.parserOptions.ecmaFeatures.experimentalObjectRestSpreadoption was removed as a result of upgradingespreeto the latest.v-ondirective with no argument and an object expression (e.g.,v-on="{foo: bar}") is now parsed to anObjectExpressionnode correctly.parserOptions.parseroption can befalse. If it'sfalse, the parser skips parsing<script>elements completely.html-indentrule to support newVSlotScopeExpressionnode.parserOptions.ecmaFeatures.experimentalObjectRestSpreadoptions in our tests.Plus, we can move this plugin to
@vue/eslint-pluginnow.@vueshorthand has been supported since ESLint 5.0.0.