Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

⭐️ New: Support ESLint 5 #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChristianMurphy wants to merge 2 commits into vuejs:master from ChristianMurphy:eslint-5

Conversation

@ChristianMurphy
Copy link

@ChristianMurphy ChristianMurphy commented Jun 24, 2018
edited
Loading

https://eslint.org/blog/2018/06/eslint-v5.0.0-released
ESLint 5 drops support for Node 4, updated CI accordingly.

erickwilder, edmorley, hans-lizihan, gluons, Berkmann18, and dtc-takuoba reacted with thumbs up emoji
@ChristianMurphy ChristianMurphy changed the title (削除) Support ESLint 5 (削除ここまで) (追記) ⭐️ New: Support ESLint 5 (追記ここまで) Jun 24, 2018
Copy link
Member

Thank you for this PR.

I'm seeing a parser problem: vuejs/vue-eslint-parser#26
I think that we have to resolve that issue before support 5.0.0.

ChristianMurphy reacted with thumbs up emoji

Copy link
Contributor

How about now

Copy link
Member

I think this change should be released in a new major version of eslint-plugin-vue. Currently build fails, as vue-eslint-parser requires eslint@5 as peer dependency, and we can't drop Node 4 support out of the blue. I'm going to prepare new beta soon, and will try include this change and drop support for Node 4 there. Thanks for working on it @ChristianMurphy

ChristianMurphy, niksy, patricklewis, ydfzgyj, mysticatea, and OmgImAlexis reacted with thumbs up emoji

Copy link
Member

I'm closing this one in favor of #532 where @mysticatea updated also mentioned parser :)

clarkdo added a commit to nuxt/nuxt that referenced this pull request Aug 31, 2018
- [ ] babel-eslint babel/babel-eslint#664
- [x] eslint-config-standard-jsx standard/eslint-config-standard-jsx#32
- [x] eslint-config-standard to be stable release standard/eslint-config-standard#123
- [x] eslint-plugin-html
- [x] eslint-plugin-import
- [x] eslint-plugin-jest
- [x] eslint-plugin-node
- [x] eslint-plugin-promise
- [x] eslint-plugin-standard standard/eslint-plugin-standard#29
- [x] eslint-plugin-vue vuejs/eslint-plugin-vue#504
- [x] eslint-plugin-react https://github.com/yannickcr/eslint-plugin-react/releases/tag/v7.10.0 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Projects

None yet

Milestone

v5.0.0

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /