-
Notifications
You must be signed in to change notification settings - Fork 113
fix: support TypeScript v3 #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,16 +46,15 @@ export interface RenderOptions<V extends Vue, S = {}> | |
| baseElement?: Element | ||
| } | ||
|
|
||
| type ConfigurationArgs = [ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. out of curiosity, is this just a syntax change because TS 3.x does not support this type definition syntax? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct - I believe that format is called "named tuple" which is a new TS v4 feature. |
||
| localVue: typeof Vue, | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| store: Store<any>, | ||
| router: Router, | ||
| ] | ||
|
|
||
| export type ConfigurationCallback<V extends Vue> = | ||
| | ((...args: ConfigurationArgs) => Partial<ThisTypedMountOptions<V>>) | ||
| | ((...args: ConfigurationArgs) => void) | ||
| | (( | ||
| localVue: typeof Vue, | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| store: Store<any>, | ||
| router: Router, | ||
| ) => Partial<ThisTypedMountOptions<V>>) | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| | ((localVue: typeof Vue, store: Store<any>, router: Router) => void) | ||
|
|
||
| export function render<V extends Vue>( | ||
| TestComponent: VueClass<V> | ComponentOptions<V>, | ||
|
|
||