-
Notifications
You must be signed in to change notification settings - Fork 113
fix: support TypeScript v3 #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Merging #241 (b6449f3) into master (96c0c2d) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #241 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 3 3 Lines 99 99 Branches 34 34 ========================================= Hits 99 99
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 96c0c2d...b6449f3. Read the comment docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity, is this just a syntax change because TS 3.x does not support this type definition syntax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct - I believe that format is called "named tuple" which is a new TS v4 feature.
Uh oh!
There was an error while loading. Please reload this page.
I'm not sure if there's a more clever way to do this, but this should work. The linked issue has a reproduction example.
Fixes #240