-
Notifications
You must be signed in to change notification settings - Fork 33
#10 - clean up document targets and components #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10 - clean up document targets and components #19
Conversation
tests/render.spec.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
output here is dependent on previous tests,
- before:
<div></div><div></div><div></div><div></div><main data-testid=\"custom-target\"></main>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the body will be entirely empty after this great addition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @EmilTholin. It should be empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed is happening, as we can see in the failed build on travis:
i bet it was some kind of local jest cache, running with --no-cache seems to have fixed it!
thanks @EmilTholin @benmonro
Uh oh!
There was an error while loading. Please reload this page.
addressing discussion from #10