Commit 9e6594d

oieduardorabelobenmonro

authored and

committed

fix: clean up document targets and components (#19)

* clean up document targets and components * jest cache was returning `<div></div>`, running with `--no-cache` fixed it * we can safely ignore `else` for code coverage here - https://github.com/gotwarlost/istanbul/blob/master/ignoring-code-for-coverage.md#ignore-an-else-path

1 parent 8ed5e12 commit 9e6594dCopy full SHA for 9e6594d

File tree

+15

-2

lines changed

+15

-2

lines changed

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ export const render = (Component, {target = document.createElement('div'), ...op`
`10`	`10`	`target,`
`11`	`11`	`})`
`12`	`12`
`13`		`- mountedContainers.add(component)`
	`13`	`+ mountedContainers.add({target,component})`
`14`	`14`	`return {`
`15`	`15`	`component,`
`16`	`16`	`// eslint-disable-next-line no-console`
`@@ -20,7 +20,12 @@ export const render = (Component, {target = document.createElement('div'), ...op`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`const cleanupAtContainer = container => {`
`23`		`- container.$destroy()`
	`23`	`+ const {target, component} = container`
	`24`	`+ component.$destroy()`
	`25`	`+ /* istanbul ignore else */`
	`26`	`+ if (target.parentNode === document.body) {`
	`27`	`+ document.body.removeChild(target)`
	`28`	`+ }`
`24`	`29`	`mountedContainers.delete(container)`
`25`	`30`	`}`
`26`	`31`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,13 +38,17 @@ describe('render', () => {`
`38`	`38`	`})`
`39`	`39`
`40`	`40`	`test('debug', () => {`
	`41`	`+ const originalConsole = global.console`
	`42`	`+`
`41`	`43`	`global.console = {log: jest.fn()}`
`42`	`44`
`43`	`45`	`const {debug} = render(App)`
`44`	`46`
`45`	`47`	`debug()`
`46`	`48`
`47`	`49`	`expect(global.console.log).toHaveBeenCalledWith(prettyDOM(document.body))`
	`50`	`+`
	`51`	`+ global.console = originalConsole`
`48`	`52`	`})`
`49`	`53`
`50`	`54`	`test('custom container target', () => {`
`@@ -61,4 +65,8 @@ describe('render', () => {`
`61`	`65`	`expect(getByText('Hello world!')).toBeInTheDocument()`
`62`	`66`	`expect(getByTestId('custom-target')).toBeInTheDocument()`
`63`	`67`	`})`
	`68`	`+`
	`69`	`+ test('after each test above, document is clean from targets and components', () => {`
	`70`	`+ expect(document.body.innerHTML).toBe('')`
	`71`	`+ })`
`64`	`72`	`})`

Comments

(0)