Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Prefer UInt(bitPattern:) for object id to guarantee uniqueness #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kateinoigakukun merged 1 commit into main from katei/uint-bitpat
Dec 19, 2022

Conversation

@kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Dec 19, 2022

Close #218

j-f1 reacted with heart emoji
@kateinoigakukun kateinoigakukun changed the title (削除) Prefer `UInt(bitPattern:)P for object id to guarantee uniqueness (削除ここまで) (追記) Prefer UInt(bitPattern:) for object id to guarantee uniqueness (追記ここまで) Dec 19, 2022
Copy link
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Dec 19, 2022 •
edited
Loading

Time Change: -141ms (0%)

Total Time: 20,533ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 23ms -2ms (8%) ✅
Serialization/JavaScript function call through Wasm import with int 22ms -1ms (6%) ✅
View Unchanged
Test name Duration Change
Serialization/JavaScript function call from Swift 194ms -4ms (2%)
Serialization/Swift Int to JavaScript with assignment 515ms +3ms (0%)
Serialization/Swift Int to JavaScript with call 1,607ms -19ms (1%)
Serialization/JavaScript Number to Swift Int 529ms -6ms (1%)
Serialization/Swift String to JavaScript with assignment 591ms -6ms (1%)
Serialization/Swift String to JavaScript with call 1,709ms -49ms (2%)
Serialization/JavaScript String to Swift String 6,334ms -161ms (2%)
Object heap/Increment and decrement RC 8,987ms +107ms (1%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 4ms
Serialization/Assign JavaScript number directly 3ms
Serialization/Call with JavaScript number directly 7ms
Serialization/Write JavaScript string directly 4ms
Serialization/Call with JavaScript string directly 4ms

Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-f1 j-f1 j-f1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JSClosure will be overriden from other closure

AltStyle によって変換されたページ (->オリジナル) /