Commit dbf7a88

authored

Prefer UInt(bitPattern:) for object id to guarantee uniqueness (#219)

Prefer UInt(bitPattern:) for object id to guarantee uniqueness Close #218

1 parent 99c9965 commit dbf7a88Copy full SHA for dbf7a88

File tree

-3

lines changed

Sources
- JavaScriptKit/FundamentalObjects
  - JSClosure.swift
- _CJavaScriptKit/include
  - _CJavaScriptKit.h

-3

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public class JSOneshotClosure: JSObject, JSClosureProtocol {`
`20`	`20`	`super.init(id: 0)`
`21`	`21`
`22`	`22`	`// 2. Create a new JavaScript function which calls the given Swift function.`
`23`		`- hostFuncRef = JavaScriptHostFuncRef(bitPattern: Int32(ObjectIdentifier(self).hashValue))`
	`23`	`+ hostFuncRef = JavaScriptHostFuncRef(bitPattern: ObjectIdentifier(self))`
`24`	`24`	`id = withExtendedLifetime(JSString(file)) { file in`
`25`	`25`	`_create_function(hostFuncRef, line, file.asInternalJSRef())`
`26`	`26`	`}`
`@@ -86,7 +86,7 @@ public class JSClosure: JSObject, JSClosureProtocol {`
`86`	`86`	`super.init(id: 0)`
`87`	`87`
`88`	`88`	`// 2. Create a new JavaScript function which calls the given Swift function.`
`89`		`- hostFuncRef = JavaScriptHostFuncRef(bitPattern: Int32(ObjectIdentifier(self).hashValue))`
	`89`	`+ hostFuncRef = JavaScriptHostFuncRef(bitPattern: ObjectIdentifier(self))`
`90`	`90`	`id = withExtendedLifetime(JSString(file)) { file in`
`91`	`91`	`_create_function(hostFuncRef, line, file.asInternalJSRef())`
`92`	`92`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`typedef unsigned int JavaScriptObjectRef;`
`11`	`11`	/// `JavaScriptHostFuncRef` represents Swift closure that is referenced by JavaScript side.
`12`	`12`	/// This value is produced by `JSClosure`.
`13`		`-typedef unsigned int JavaScriptHostFuncRef;`
	`13`	`+typedef uintptr_t JavaScriptHostFuncRef;`
`14`	`14`
`15`	`15`	/// `JavaScriptValueKind` represents the kind of JavaScript primitive value.
`16`	`16`	`typedef enum __attribute__((enum_extensibility(closed))) {`

Comments

(0)