Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: add /guides/.../welcome route redirect -> /quick-start #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iyiolacak wants to merge 3 commits into solidjs:main
base: main
Choose a base branch
Loading
from iyiolacak:fix/welcome-404-redirect
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/middleware/legacy-routes-redirect.ts
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,8 @@ const LEGACY_ROUTES = {

"/solid-router/reference/response-helpers/revalidate":
"/solid-router/reference/data-apis/revalidate",

"/guides/tutorials/getting-started-with-solid/welcome": "/quick-start",
} as const;

function isLegacyRoute(path: string): path is keyof typeof LEGACY_ROUTES {
Expand Down
37 changes: 37 additions & 0 deletions src/routes/guides/tutorials/getting-started-with-solid/welcome.tsx
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import { onMount } from "solid-js";

/**
* Server redirect. Immediate HTTP redirect for requests handled on the server.
* 301 for permanent. 301s may be cached by browsers/CDNs.
*/
export function GET() {
return new Response(null, {
status: 302,
headers: { Location: "/quick-start" },
});
}
/**
* Client fallback: for environments where GET isn't invoked the client will
* execute this and replace the location. Keeps UX smooth when navigating client-side.
*/
export default function WelcomeRedirect() {
onMount(() => {
// use replace so the redirect doesn't add an extra history entry
try {
window.location.replace("https://docs.solidjs.com/quick-start");
} catch {
// fallback: set href
window.location.href = "https://docs.solidjs.com/quick-start";
}
});

return (
<main style={{ "font-family": "system-ui, -apple-system, 'Segoe UI', Roboto, sans-serif", padding: "2rem" }}>
<h1>Redirecting...</h1>
<p>
You are being redirected to the Quick Start page. If the redirect does not happen automatically,{" "}
<a href="https://docs.solidjs.com/quick-start">click here to continue</a>.
</p>
</main>
);
}

AltStyle によって変換されたページ (->オリジナル) /