-
Notifications
You must be signed in to change notification settings - Fork 329
docs: add /guides/.../welcome route redirect -> /quick-start #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
7ba4c90 to
8e0a8dd
Compare
Couldn't we just fix the link on the old docs instead of setting up a redirect here for the bad link?
This would at least guarantee, if this link was in use somewhere else in the internet or in the SolidJS docs.
I am happy to just change the href if you want to but I wasn't sure if this URL was used on somewhere else both in the docs or external web.
I believe this can be put in the legacy redirect page - https://github.com/solidjs/solid-docs/blob/main/src/middleware/legacy-routes-redirect.ts
@iyiolacak did you want to make this change?
@brenelz Yup, that'd be better for consistency. I'll move it into legacy-routes-redirect.ts in my next commit and rollback the new route.
Added a few labels to indicate this is pending review and added @/LadyBluenotes as reviewer so you can ping when the redirect is moved to the middleware
This way the PR doesn't look like it's ready to merge :)
13a8fff to
3842fd9
Compare
@LadyBluenotes Sorry for late push.
3842fd9
Looks fine but I'm not sure what happened in that force push? That content is odd and I did not mean that
Uh oh!
There was an error while loading. Please reload this page.
Description (required)
Fix a broken link path that leads new users to a 404.
How I encountered it
- The "here" link points to
https://docs.solidjs.com/guides/tutorials/getting-started-with-solid/welcomeWhat this PR does
src/routes/guides/tutorials/getting-started-with-solid/welcome.tsx/quick-start(via standard WebResponsewithLocation)window.location.replace) for SPA navigationsTesting
pnpm dev/guides/tutorials/getting-started-with-solid/welcomeredirects to/quick-startRelated issues & labels
documentation,bug,good first issue