-
-
Notifications
You must be signed in to change notification settings - Fork 32
chore!: upgrade is-url-superb to ^4.0.0 #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Breaking*: Require Node.js 10 - remove url-regex dependency
I think this is a reasonable, low footprint approach. I'll download your fork to fix the analysis run.
This was referenced Sep 16, 2020
I'm not sure if it's an issue in 4.0/0 or an interaction with my setup (ejected but reasonably standard CRA 3.x) still I can't use the new version, receiving:
./src/common/components/Container/Container.css
TypeError: valueParser is not a function
I'll open an issue if I can confirm it's not related to my setup, or if I better identify the cause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Requires node V10
Please Describe Your Changes
upgrade is-url-superb to ^4.0.0 to fix audit. Also removes url-regex as a dep.
Related: #120
In the other PR, you mentioned not wanting to add any new code (#124 (comment)), would this small change be fine?