-
-
Notifications
You must be signed in to change notification settings - Fork 32
Upgrade is-url-superb from ^3.0.0 to ^4.0.0 #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
davilima6
wants to merge
1
commit into
shellscape:master
from
davilima6:remove-unused-unsafe-dep-url-regex
Closed
Upgrade is-url-superb from ^3.0.0 to ^4.0.0 #122
davilima6
wants to merge
1
commit into
shellscape:master
from
davilima6:remove-unused-unsafe-dep-url-regex
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah for more context see the discussion starting here: #119 (comment)
the new version does not depend on url-regex, which has a up until now unpatched high vulnerability https://www.npmjs.com/advisories/1550 therefore we remove the non-direct dependency on url-regex, which apparently was only there to force a resolution to a newest version than the one brought in by is-url-superb@^3.0.0
@davilima6
davilima6
changed the title
(削除) upgrade is-url-superb from ^3.0.0 to ^4.0.0 (削除ここまで)
(追記) Upgrade is-url-superb from ^3.0.0 to ^4.0.0 (追記ここまで)
Aug 17, 2020
Closing in favor of #125. As noted on your other PR, I do sincerely and truthfully appreciate the work you put in on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
WIP: tests do not pass. Is there anyone more familiar around? :)
The major 4.0.0 drop dependency on
url-regex, which has a up until now unpatched high vulnerability https://www.npmjs.com/advisories/1550Next I remove the non-direct dependency of
postcss-values-parseronurl-regex, which I suppose was there to keep the version stable in case is-url-superb@^3.0.0 updated it, since it not imported anywhere in thispostcss-values-parser.This PR contains:
Breaking Changes?
New major of
is-url-superb:See https://github.com/sindresorhus/is-url-superb/releases/tag/v4.0.0
Please Describe Your Changes
This relates to #120