Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

vue 3 support (without changed /dist) #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morr wants to merge 1 commit into shakee93:master
base: master
Choose a base branch
Loading
from morr:vue-3
Open

Conversation

@morr
Copy link

@morr morr commented Jul 13, 2021

No description provided.

Casmo, ahules, and ankurk91 reacted with thumbs up emoji
Comment on lines +11 to +12
app.component('toasted', ToastComponent);
app.config.globalProperties.$toasted = Toast;
Copy link

@adrianjost adrianjost Feb 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is app coming from? I doubt that it is a global variable.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L5: fix argument Vue -> app

adrianjost and sir-geronimo reacted with thumbs up emoji
Copy link

@sir-geronimo sir-geronimo Dec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morr You need to rename Vue to app on the install function or revert to the previous name.

Suggested change
app.component('toasted', ToastComponent);
app.config.globalProperties.$toasted = Toast;
Vue.component('toasted', ToastComponent);
Vue.config.globalProperties.$toasted = Toast;

Copy link

Why is this not merged yet?

Copy link

ankurk91 commented May 10, 2023
edited
Loading

I wish if this could be merged

Meanwhile check this
https://github.com/hoppscotch/vue-toasted

sir-geronimo reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@d-mato d-mato d-mato left review comments

@sir-geronimo sir-geronimo sir-geronimo left review comments

@adrianjost adrianjost adrianjost left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /