vue 3 support (without changed /dist) #207

Original file line number	Diff line number	Diff line change
Expand Up		@@ -8,8 +8,8 @@ const Toasted = {
		}

		const Toast = new T(options);
	Vue.component('toasted', ToastComponent);
	Vue.toasted = Vue.prototype.$toasted = Toast;
	app.component('toasted', ToastComponent);
	app.config.globalProperties.$toasted = Toast;
Comment on lines +11 to +12 Copy link @adrianjost adrianjost Feb 7, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. where is `app` coming from? I doubt that it is a global variable. Copy link @d-mato d-mato Feb 11, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. L5: fix argument `Vue -> app` adrianjost and sir-geronimo reacted with thumbs up emoji Copy link @sir-geronimo sir-geronimo Dec 29, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. @morr You need to rename `Vue` to `app` on the `install` function or revert to the previous name. Suggested change app.component('toasted', ToastComponent); app.config.globalProperties.$toasted = Toast; Vue.component('toasted', ToastComponent); Vue.config.globalProperties.$toasted = Toast;
		}
		};

Expand Down

11 changes: 3 additions & 8 deletions types/index.d.ts

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -1,5 +1,4 @@
	import { Vue, VueConstructor } from 'vue/types/vue'
	import { PluginFunction } from "vue"
	import { App, PluginFunction } from 'vue';

		export interface ToastObject {
		// html element of the toast
Expand Down Expand Up		@@ -158,12 +157,8 @@ declare class ToastedPlugin {
		static install: PluginFunction<ToastOptions>
		}

	declare module 'vue/types/vue' {
	interface VueConstructor {
	toasted: Toasted
	}

	interface Vue {
	declare module '@vue/runtime-core' {
	interface ComponentCustomProperties {
		$toasted: Toasted
		}
		}
Expand Down

Navigation Menu