Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve tests result consistency #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justin808 merged 16 commits into master from reduce-test-failures
Jan 5, 2024
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d67b86d
Increase wait time for capybara
ahangarha Dec 31, 2023
c9d22e3
run bin/rspec
ahangarha Dec 31, 2023
3455e55
Increase wait time for capybara
ahangarha Dec 31, 2023
71a779d
Improve rescript tests
ahangarha Dec 31, 2023
79ed86d
Chack page load rather forcing sleep
ahangarha Jan 1, 2024
fc3f6b8
Fix false positive test pass in turbu spec
ahangarha Jan 1, 2024
a5ddd57
Change type to feature
ahangarha Jan 1, 2024
599b2bc
Comment back capybara default max wait time config
ahangarha Jan 1, 2024
a6190eb
Revert "run bin/rspec"
ahangarha Jan 1, 2024
244a390
Revert "Change type to feature"
ahangarha Jan 2, 2024
9314c70
Remove unneeded Capybara config
ahangarha Jan 2, 2024
a56a164
Remove unneeded js and type metadata in system specs
ahangarha Jan 2, 2024
b0eaa5f
Improve test by checking comment on the page
ahangarha Jan 4, 2024
facb4b0
Combine the two similar tests
ahangarha Jan 4, 2024
9b12367
updated to unique comments
justin808 Jan 5, 2024
338f9f4
lint
justin808 Jan 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "run bin/rspec"
This reverts commit c9d22e3.
  • Loading branch information
ahangarha committed Jan 1, 2024
commit a6190ebd3c5133017708543dc3ef8da0e0a7ed7c
2 changes: 1 addition & 1 deletion lib/tasks/ci.rake
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ if Rails.env.development? || Rails.env.test?

task rspec_tests: :environment do
puts Rainbow("Running RSpec tests").green
sh "./bin/rspec"
sh "rspec"
end

task build_rescript: :environment do
Expand Down

AltStyle によって変換されたページ (->オリジナル) /