-
Couldn't load subscription status.
- Fork 380
Improve tests result consistency #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In this commit, a deply is put between UI interaction and database check. This, fixed false positive test pass for not updating database on empty form submission.
f46430b to
79ed86d
Compare
spec/stimulus/turbo_spec.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahangarha, this is a very strange assertion!
Please add self-review comments for WTF's like this!
CC: @Judahmeek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned in the comment above that line, we need to put some delay before getting assertion for comment count change. Before I fixed it with sleep but that is not efficient. This assertion makes it more efficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expect page to display the new comment in the right format block (not in the input field).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already had a test to ensure the new comment is displayed on the page. This test was to ensure the comment was added to the database.
Now, we combine them into one test with multiple assertions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure the text is some unique value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this test runs, we have a fresh database.
spec/stimulus/turbo_spec.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expect page to display the new comment in the right format block (not in the input field).
spec/stimulus/turbo_spec.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahangarha see my changes.
Uh oh!
There was an error while loading. Please reload this page.
The changes in
rescript_spec.rbandturbo_spec.rbimprove our test accuracy.(削除) The changes inspec/system/*fix the test failure when these tests run before others (leading to their failure). (削除ここまで)(削除) I am not sure why we have tests in thesystemdirectory that should have the type offeature, but it fixes our issues. I need to study deeper to understand what is happening under the hood. (削除ここまで)(削除) Should I move thesefeaturetests into thefeaturedirectory, or we can keep them this way for now? (削除ここまで)This change is Reviewable