Skip to content

Justin improve docker image #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

justin808 wants to merge 27 commits into master from justin-improve-docker-image

Closed

Justin improve docker image #574

Changes from 1 commit

Commits

Show all changes

Select commit Hold shift + click to select a range

Prepare db only if rails server is running

ahangarha Oct 29, 2023

Update root Dockerfile based on Rails Dockerfile

ahangarha Oct 29, 2023

Remove bootsnap related lines

ahangarha Oct 29, 2023

ahangarha Oct 29, 2023

Fix execution of the command for generative locale

ahangarha Oct 29, 2023

Remove storage dir from the chown command

ahangarha Oct 29, 2023

Move node installation to the base stage

ahangarha Nov 16, 2023

Rename the working dir to /app

ahangarha Nov 16, 2023

Move build steps into cpln dockerfile

ahangarha Dec 9, 2023

Move customizations into dedicated Dockerfiles

ahangarha Dec 9, 2023

Use full command for rails server

ahangarha Dec 9, 2023

Use bash to run the entrypoint script

ahangarha Dec 9, 2023

Add documentation for using base docker image

ahangarha Dec 9, 2023

Add yarn res:build to the new dockerfile

ahangarha Dec 10, 2023

Improve documentation

ahangarha Dec 15, 2023

Change the repository of the base image

ahangarha Dec 15, 2023

Add maintainer guideline

ahangarha Dec 15, 2023

justin808 Dec 25, 2023

Updated Docker file

justin808 Dec 26, 2023

Add Docker Build

justin808 Dec 28, 2023

justin808 Dec 28, 2023

justin808 Dec 28, 2023

justin808 Dec 28, 2023

justin808 Dec 28, 2023

justin808 Dec 28, 2023

justin808 Dec 28, 2023

justin808 Dec 28, 2023

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

Move node installation to the base stage

Loading branch information

@ahangarha @justin808

ahangarha authored and justin808 committed Dec 28, 2023

commit 44af5a070217b63fec18aca3e891d9bccb5e0a2f

26 changes: 13 additions & 13 deletions Dockerfile

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -4,19 +4,6 @@
		ARG RUBY_VERSION=3.1.2
		FROM registry.docker.com/library/ruby:$RUBY_VERSION-slim as base

	# Rails app lives here
	WORKDIR /rails

	# Set production environment
	ENV RAILS_ENV="production" \
	BUNDLE_DEPLOYMENT="1" \
	BUNDLE_PATH="/usr/local/bundle" \
	BUNDLE_WITHOUT="development"


	# Throw-away build stage to reduce size of final image
	FROM base as build

		# Install packages needed to build gems and node modules
		RUN apt-get update -qq && \
		apt-get install --no-install-recommends -y build-essential curl git libpq-dev libvips node-gyp pkg-config python-is-python3
Expand All		@@ -31,6 +18,19 @@ RUN curl -sL https://github.com/nodenv/node-build/archive/master.tar.gz \| tar xz
		npm install -g yarn@$YARN_VERSION && \
		rm -rf /tmp/node-build-master

	# Rails app lives here
	WORKDIR /rails

	# Set production environment
	ENV RAILS_ENV="production" \
	BUNDLE_DEPLOYMENT="1" \
	BUNDLE_PATH="/usr/local/bundle" \
	BUNDLE_WITHOUT="development"


	# Throw-away build stage to reduce size of final image
	FROM base as build

		# Install application gems
		COPY Gemfile Gemfile.lock ./
		RUN bundle install && \
Expand Down