-
Notifications
You must be signed in to change notification settings - Fork 380
Justin improve docker image #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
589813e
Prepare db only if rails server is running
ahangarha 3a71934
Update root Dockerfile based on Rails Dockerfile
ahangarha 62175bf
Remove bootsnap related lines
ahangarha 1fec261
Use bin/rails
ahangarha 547e992
Fix execution of the command for generative locale
ahangarha e6907ed
Remove storage dir from the chown command
ahangarha 44af5a0
Move node installation to the base stage
ahangarha c5c0d4b
Rename the working dir to /app
ahangarha 8c231c9
Move build steps into cpln dockerfile
ahangarha 5ece4c3
Move customizations into dedicated Dockerfiles
ahangarha 7419760
Use full command for rails server
ahangarha 7f9615f
Use bash to run the entrypoint script
ahangarha 4834479
Add documentation for using base docker image
ahangarha 9d21b0f
Add yarn res:build to the new dockerfile
ahangarha 803e46b
Improve documentation
ahangarha a1043fe
Change the repository of the base image
ahangarha 0f59a18
Add maintainer guideline
ahangarha 25a43b4
WIP
justin808 98290a4
Updated Docker file
justin808 6d9cdd4
Add Docker Build
justin808 c2d7e31
WIP
justin808 d1b3729
WIP
justin808 fb81a81
WIP
justin808 ce0b8a3
WIP
justin808 d3d5d8c
WIP
justin808 b9b63c1
WIP
justin808 e284c32
WIP
justin808 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Rename the working dir to /app
- Loading branch information
commit c5c0d4b43f99c684fc519df97d7101cf6a57cc1d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.