Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Create Footer component (#499) #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justin808 merged 4 commits into shakacode:master from yassa-tamer:create-footer-component
Jul 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/views/layouts/application.html.erb
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
<%= yield %>
</div>

<%= react_component "Footer" %>

<!-- This is a placeholder for ReactOnRails to know where to render the store props for
client side hydration -->
<%= redux_store_hydration_data %>
Expand Down
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,6 @@ export default class CommentScreen extends BaseComponent {
actions={actions}
ajaxCounter={data.get('ajaxCounter')}
/>
<div className="container">
<a href="http://www.shakacode.com">
<h3>
<div className={css.logo} />
Example of styling using image-url and Open Sans Light custom font
</h3>
</a>
<a href="https://twitter.com/railsonmaui">
<div className={css.twitterImage} />
Rails On Maui on Twitter
</a>
</div>
</div>
</div>
);
Expand Down
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,4 @@
padding: 1em 1.5em;
}

.logo {
background: url('./images/railsonmaui.png') no-repeat left bottom;
display: inline-block;
height: 40px;
margin-right: 10px;
width: 146px;
}

.twitterImage {
background: url('./images/twitter_64.png') no-repeat;
height: 64px;
width: 64px;
}
22 changes: 22 additions & 0 deletions client/app/bundles/comments/components/Footer/Footer.jsx
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import React from 'react';
import BaseComponent from 'libs/components/BaseComponent';
import css from './Footer.module.scss';

export default class Footer extends BaseComponent {
render() {
return (
<div className="container">
<a href="http://www.shakacode.com">
<h3>
<div className={css.logo} />
Example of styling using image-url and Open Sans Light custom font
</h3>
</a>
<a href="https://twitter.com/railsonmaui">
<div className={css.twitterImage} />
Rails On Maui on Twitter
</a>
</div>
);
}
}
13 changes: 13 additions & 0 deletions client/app/bundles/comments/components/Footer/Footer.module.scss
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
.logo {
background: url('./images/railsonmaui.png') no-repeat left bottom;
display: inline-block;
height: 40px;
margin-right: 10px;
width: 146px;
}

.twitterImage {
background: url('./images/twitter_64.png') no-repeat;
height: 64px;
width: 64px;
}
2 changes: 2 additions & 0 deletions client/app/bundles/comments/startup/serverRegistration.jsx
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@ import SimpleCommentScreen from '../components/SimpleCommentScreen/SimpleComment
import NavigationBarApp from './NavigationBarApp.jsx';
import routerCommentsStore from '../store/routerCommentsStore';
import commentsStore from '../store/commentsStore';
import Footer from '../components/Footer/Footer';

ReactOnRails.register({
App,
RouterApp,
NavigationBarApp,
SimpleCommentScreen,
Footer,
});

ReactOnRails.registerStore({
Expand Down
2 changes: 2 additions & 0 deletions client/app/packs/client-bundle.js
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import SimpleCommentScreen from '../bundles/comments/components/SimpleCommentScr
import routerCommentsStore from '../bundles/comments/store/routerCommentsStore';
import commentsStore from '../bundles/comments/store/commentsStore';
import NavigationBarApp from '../bundles/comments/startup/NavigationBarApp.jsx';
import Footer from '../bundles/comments/components/Footer/Footer.jsx';

ReactOnRails.setOptions({
// traceTurbolinks: process.env.TRACE_TURBOLINKS, // eslint-disable-line no-undef
Expand All @@ -22,6 +23,7 @@ ReactOnRails.register({
RouterApp,
NavigationBarApp,
SimpleCommentScreen,
Footer,
});

ReactOnRails.registerStore({
Expand Down
2 changes: 2 additions & 0 deletions client/app/packs/server-bundle.js
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@ import SimpleCommentScreen from '../bundles/comments/components/SimpleCommentScr
import NavigationBarApp from '../bundles/comments/startup/NavigationBarApp';
import routerCommentsStore from '../bundles/comments/store/routerCommentsStore';
import commentsStore from '../bundles/comments/store/commentsStore';
import Footer from '../bundles/comments/components/Footer/Footer';

ReactOnRails.register({
App,
RouterApp,
NavigationBarApp,
SimpleCommentScreen,
Footer,
});

ReactOnRails.registerStore({
Expand Down

AltStyle によって変換されたページ (->オリジナル) /