-
Notifications
You must be signed in to change notification settings - Fork 380
Create Footer component (#499) #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Footer component (#499) #534
Conversation
This commit basically should add a footer to the Simple React page, But The footer logic is used in more than one place so a Footer component is created and called wherever it is needed. Resolves shakacode#499
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good move
I see duplicate content at the bottom of the page.
What do you think about the Classic Rails page? What to do there?
If we can have the same navigation bar on all pages, we should be able to have a footer too.
Yes, Sorry for forgetting it. I removed the duplicate content.
If we want the footer on every page, I suggest putting it on the application layout with the navigation bar.
The Footer should appear in all the pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There are minor issues to fix. After that, I think this PR is ready to get merged.
client/app/bundles/comments/components/Footer/Footer.module.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍🏾
@justin808 Now we have a footer on all pages. Do you have any comments here?
I think we need to update the branding in the footer. Also, the UI/UX can get improved.
I propose to have a separate task for these two.
Thanks @Yassa-hue
Uh oh!
There was an error while loading. Please reload this page.
This commit basically should add a footer to the Simple React page, But The footer logic is used in more than one place so a Footer component is created and called wherever it is needed.
Resolves #499
This change is Reviewable