This repository was archived by the owner on Aug 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
Expose panic formatting in API #24
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdanilo
commented
May 10, 2022
@alexcrichton @fitzgen do you think it could be merged to this repo? We do not want to keep a local copy of it because it increases the maintenance burden :) I'm pinging you because other PRs are waiting really long time here, so I thought it might be helpful to let you know that this one is opened as well :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm working on an Electron application, Enso. Enso needs to do multiple things in our panic hook: We have an application-specific API to submit the backtrace to, but we'd also like to display it with
console.error. We want to minimize duplication of the functionality defined inconsole_error_panic_hook--especially the backtrace formatting, since it addresses browser subtleties.This proposed change introduces a lower level function to the API, exposing the panic formatting functionality for use from another hook.
(Also, it increments the release version in
Cargo.tomlto match the currently-released version.)