Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

TEST ONLY #15227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kirklandsign wants to merge 3 commits into release/1.0
base: release/1.0
Choose a base branch
Loading
from kirk-debug-audio
Draft

TEST ONLY #15227

kirklandsign wants to merge 3 commits into release/1.0 from kirk-debug-audio

Conversation

@kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Oct 17, 2025

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

Copy link

pytorch-bot bot commented Oct 17, 2025
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15227

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Cancelled Job, 1 Unrelated Failure

As of commit eec63eb with merge base e0dda90 (image ):

NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2025
.echo = static_cast<bool>(echo),
.seq_len = seq_len,
.temperature = temperature_,
.max_new_tokens = 256,
Copy link
Contributor Author

@kirklandsign kirklandsign Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to set this!

Comment on lines +114 to +125
std::string result = "Image: ";
if (is_uint8()) {
result += "uint8_t";
} else if (is_float()) {
result += "float";
} else {
result += "unknown";
}
result += "width: " + std::to_string(width_) + ", ";
result += "height: " + std::to_string(height_) + ", ";
result += "channels: " + std::to_string(channels_);
return result;
Copy link
Contributor

@larryliu0820 larryliu0820 Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use string stream to avoid copying

kirklandsign reacted with thumbs up emoji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 larryliu0820 left review comments

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng will be requested when the pull request is marked ready for review jackzhxng is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok will be requested when the pull request is marked ready for review swolchok is a code owner

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin will be requested when the pull request is marked ready for review mergennachin is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq will be requested when the pull request is marked ready for review lucylq is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /