Skip to content

pr05 Typescript Migration #17: Add typecheck to ci #3699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

raclim merged 3 commits into processing:develop from clairep94:add_typecheck_to_ci

Oct 26, 2025

+11 −11

Merged

pr05 Typescript Migration #17: Add typecheck to ci #3699

Changes from all commits

Commits

Show all changes

Select commit Hold shift + click to select a range

fix stray type-error

clairep94 Oct 24, 2025

add typecheck to PR checks

clairep94 Oct 24, 2025

Merge branch 'develop' into add_typecheck_to_ci

raclim Oct 26, 2025

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

19 changes: 9 additions & 10 deletions .github/workflows/test.yml

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -7,13 +7,12 @@ jobs:
		name: Test and lint code base
		runs-on: ubuntu-latest
		steps:
	- uses: actions/checkout@v2
	- name: Use Node.js
	uses: actions/setup-node@v1
	with:
	node-version: '18.20.x'
	- run: npm install
	- run: npm run test
	- run: npm run lint


	- uses: actions/checkout@v2
	- name: Use Node.js
	uses: actions/setup-node@v1
	with:
	node-version: '18.20.x'
	- run: npm install
	- run: npm run test
	- run: npm run typecheck
	- run: npm run lint

3 changes: 2 additions & 1 deletion server/routes/passport.routes.ts

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -1,5 +1,6 @@
		import { Router, Request, Response, NextFunction } from 'express';
		import passport from 'passport';
	import { UserDocument } from '../types';

		const router = Router();

Expand All		@@ -11,7 +12,7 @@ const authenticateOAuth = (service: string) => (
		passport.authenticate(
		service,
		{ failureRedirect: '/login' },
	(err: unknown, user: unknown) => {
	(err: unknown, user: UserDocument) => {
		if (err) {
		// use query string param to show error;
		res.redirect(`/account?error=${service}`);
Expand Down

Loading