-
-
Couldn't load subscription status.
- Fork 1.6k
pr05 Typescript Migration #17: Add typecheck to ci #3699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raclim
raclim
approved these changes
Oct 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this, will merge this in!
@clairep94
clairep94
changed the title
(削除) pr05: Add typecheck to ci (削除ここまで)
(追記) pr05 Typescript Migration #17: Add typecheck to ci (追記ここまで)
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #issue-number
- Replacing TS
- It was on the precommit hook but may have been bypassed
Screenshot 2025年10月24日 at 16 35 44anybyunknown, as usinganyis highly NOT recommended #3661 resulted in a typeerror that was uncaught on CI as we did have typecheck on CI yettypecheckto CIChanges:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123